Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1451)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 571843003: [ServivceWorker] Treat rejecting respondWith as a Network Error (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated Mike's comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
index 24172c365b61169e8e16aa52089f964c158c7942..de815b188a479e2fbd118757db22747f36ecd004 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
@@ -45,6 +45,7 @@ namespace blink {
class ExecutionContext;
class Response;
yhirano 2014/09/17 02:25:31 You don't need this declaration any more.
horo 2014/09/17 04:45:20 Done.
class WebServiceWorkerCacheStorage;
+class WebServiceWorkerResponse;
class WebURL;
class WorkerClients;
@@ -59,8 +60,9 @@ public:
virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) = 0;
virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) = 0;
- // A null response means no valid response was provided by the service worker, so fallback to native.
- virtual void didHandleFetchEvent(int fetchEventID, Response* = 0) = 0;
+ // Calling didHandleFetchEvent without response means no response was provided by the service worker in the fetch events, so fallback to native.
yhirano 2014/09/17 02:25:31 Please wrap the comment in 80 columns.
horo 2014/09/17 04:45:20 Done.
+ virtual void didHandleFetchEvent(int fetchEventID) = 0;
+ virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) = 0;
virtual void didHandleSyncEvent(int syncEventID) = 0;
virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0;

Powered by Google App Engine
This is Rietveld 408576698