Chromium Code Reviews| Index: Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h |
| diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h |
| index 24172c365b61169e8e16aa52089f964c158c7942..de815b188a479e2fbd118757db22747f36ecd004 100644 |
| --- a/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h |
| +++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h |
| @@ -45,6 +45,7 @@ namespace blink { |
| class ExecutionContext; |
| class Response; |
| class WebServiceWorkerCacheStorage; |
| +class WebServiceWorkerResponse; |
| class WebURL; |
| class WorkerClients; |
| @@ -59,8 +60,9 @@ public: |
| virtual void didHandleActivateEvent(int eventID, WebServiceWorkerEventResult) = 0; |
| virtual void didHandleInstallEvent(int installEventID, WebServiceWorkerEventResult) = 0; |
| - // A null response means no valid response was provided by the service worker, so fallback to native. |
| - virtual void didHandleFetchEvent(int fetchEventID, Response* = 0) = 0; |
| + // Calling didHandleFetchEvent without response means no response was provided by the service worker in the fetch events, so fallback to native. |
| + virtual void didHandleFetchEvent(int fetchEventID) = 0; |
| + virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse&) = 0; |
|
Mike West
2014/09/16 11:01:38
This is much cleaner, thanks!
|
| virtual void didHandleSyncEvent(int syncEventID) = 0; |
| virtual void postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) = 0; |