Issue 57183002: Fix the SSL interstitial UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57183002: Fix the SSL interstitial UMA stats (Closed)

Created:
7 years, 1 month ago by felt

Modified:
7 years, 1 month ago

Reviewers:
Patrick Dubroy, Ryan Sleevi

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the SSL interstitial UMA stats Just discovered that I broke the UMA stats during one of my recent refactorings. Here's what went wrong: The interstitial is supposed to send a FOCUS event to indicate that page load timing should start. RecordSSLBlockingPageDetailedStats only records UMA stats if the page has a non-null page load time. At some point, I deleted the code that sent the FOCUS event, so the page load time was always null. We don't need any of the timing stuff anymore, so I've gotten rid of all of it. This also fixes the bug. BUG=314416 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232809

Patch Set 1 #

Patch Set 2 : Update comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -17 lines)			Patch
M	chrome/browser/resources/ssl/ssl_errors_common.js	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.cc	View	1	8 chunks	+2 lines, -13 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

felt

Hi Ryan, just caught this bug. Can you please review this fix?

7 years, 1 month ago (2013-11-03 05:13:17 UTC) #1

felt

Hi Patrick, can you please review the tiny change to chrome/browser/resources/ssl/?

7 years, 1 month ago (2013-11-04 00:03:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/57183002/30001

7 years, 1 month ago (2013-11-04 18:36:22 UTC) #5

Message was sent while issue was closed.

Change committed as 232809

Expand Messages | Collapse Messages