Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 571813003: Fix Tab.getWebContents for downstream instrumentation tests (Closed)

Created:
6 years, 3 months ago by jdduke (slow)
Modified:
6 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Tab.getWebContents for downstream instrumentation tests Tab.getWebContents() was using JNI to fetch the WebContents object. This is undesirable for several reasons, including performance impact and thread access consistency. Remove this and prefer redirecting the query to ContentViewcore.getWebContents() instead. This fix is a temporary workaround until all downstream test sites can be patched. BUG=398263, 414445 TBR=tedchoc@chromium.org NOTRY=true Committed: https://crrev.com/9013fc8939168ed393119ce440e2630b3b68ed1c Cr-Commit-Position: refs/heads/master@{#294918}

Patch Set 1 #

Patch Set 2 : Remove native method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jdduke (slow)
tedchoc@: I'm not sure we can do much better than this for now... I'd like ...
6 years, 3 months ago (2014-09-15 21:25:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571813003/1
6 years, 3 months ago (2014-09-15 21:27:24 UTC) #4
Ted C
lgtm
6 years, 3 months ago (2014-09-15 22:36:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571813003/20001
6 years, 3 months ago (2014-09-15 22:39:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 28ecc42dfed8a63c30f405a2434ad76b866433f0
6 years, 3 months ago (2014-09-15 23:29:33 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:32:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9013fc8939168ed393119ce440e2630b3b68ed1c
Cr-Commit-Position: refs/heads/master@{#294918}

Powered by Google App Engine
This is Rietveld 408576698