Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 571773002: Default to returning success in utime. (Closed)

Created:
6 years, 3 months ago by bradn
Modified:
6 years, 3 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Default to returning success in utime. Restoring the previous behavior of nacl_io regarding utime, such that it pretends to succeed when a mount doesn't implement utime. BUG=https://code.google.com/p/chromium/issues/detail?id=414058 TEST=trybots TBR=binji@chromium.org Committed: https://crrev.com/8dc42c4dbf738d543362385bb0e2e2170a0b5edc Cr-Commit-Position: refs/heads/master@{#294759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M native_client_sdk/src/libraries/nacl_io/node.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
6 years, 3 months ago (2014-09-13 22:17:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571773002/1
6 years, 3 months ago (2014-09-13 22:17:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6b067c02d564065bc58f09a5b6f4bdf1c8a2b375
6 years, 3 months ago (2014-09-14 05:23:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8dc42c4dbf738d543362385bb0e2e2170a0b5edc Cr-Commit-Position: refs/heads/master@{#294759}
6 years, 3 months ago (2014-09-14 05:27:05 UTC) #5
binji
6 years, 3 months ago (2014-09-15 17:13:07 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698