Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/crash/app/breakpad_mac.mm

Issue 571663002: Mac: Configure Breakpad to run in-process on Yosemite. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove .h from gyp Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/breakpad.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/app/breakpad_mac.mm
diff --git a/components/crash/app/breakpad_mac.mm b/components/crash/app/breakpad_mac.mm
index 904e6bda94c60b02b5c326de211e1689e4ede99b..9f617398f1939cedc13a6113c767beee658883d8 100644
--- a/components/crash/app/breakpad_mac.mm
+++ b/components/crash/app/breakpad_mac.mm
@@ -218,6 +218,14 @@ void InitCrashReporter(const std::string& process_type) {
[breakpad_config setObject:base::SysUTF8ToNSString(dir_crash_dumps.value())
forKey:@BREAKPAD_DUMP_DIRECTORY];
+ // Temporarily run Breakpad in-process on 10.10 and later because APIs that
+ // it depends on got broken (http://crbug.com/386208).
+ // This can catch crashes in the browser process only.
+ if (is_browser && base::mac::IsOSYosemiteOrLater()) {
+ [breakpad_config setObject:[NSNumber numberWithBool:YES]
+ forKey:@BREAKPAD_IN_PROCESS];
+ }
+
// Initialize Breakpad.
gBreakpadRef = BreakpadCreate(breakpad_config);
if (!gBreakpadRef) {
« no previous file with comments | « breakpad/breakpad.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698