Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 571653003: cc: Make GetViewportForTilePriorityInContentSpace() not need intersect. (Closed)

Created:
6 years, 3 months ago by danakj
Modified:
6 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, cc-bugs_chromium.org, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Make GetViewportForTilePriorityInContentSpace() not need intersect. Currently we always intersect GetViewportForTilePriorityInContentSpace() with the visible_content_rect(), so instead just intersect before returning so we can always use that value more simply. R=boliu Committed: https://crrev.com/cc4e60d8239b6e8b2cddb44e929cd39ff8e63722 Cr-Commit-Position: refs/heads/master@{#294727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M cc/layers/picture_layer_impl.cc View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
6 years, 3 months ago (2014-09-12 21:25:32 UTC) #1
boliu
lgtm
6 years, 3 months ago (2014-09-12 21:26:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571653003/1
6 years, 3 months ago (2014-09-12 21:38:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/15156)
6 years, 3 months ago (2014-09-12 22:10:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571653003/1
6 years, 3 months ago (2014-09-13 02:04:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 25dc1e72fdfc6be19b5b5695bf9a86dee6c0231f
6 years, 3 months ago (2014-09-13 02:45:31 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 02:47:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc4e60d8239b6e8b2cddb44e929cd39ff8e63722
Cr-Commit-Position: refs/heads/master@{#294727}

Powered by Google App Engine
This is Rietveld 408576698