Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 571653002: DevTools: [SSP] consume event if it inserts a new property (Closed)

Created:
6 years, 3 months ago by lushnikov
Modified:
6 years, 3 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] consume event if it inserts a new property Currently, if you click on the selector container, there are two handlers that conflict with each other. The patch fixes the conflict. BUG=413894 R=vsevik, apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181963

Patch Set 1 #

Patch Set 2 : keeping it on the safe side #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
PTAL
6 years, 3 months ago (2014-09-12 21:06:16 UTC) #1
vsevik
lgtm
6 years, 3 months ago (2014-09-12 21:57:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571653002/20001
6 years, 3 months ago (2014-09-12 21:58:02 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/10464)
6 years, 3 months ago (2014-09-12 22:12:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571653002/20001
6 years, 3 months ago (2014-09-15 07:17:00 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 07:29:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181963

Powered by Google App Engine
This is Rietveld 408576698