Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: extensions/shell/browser/desktop_controller.h

Issue 571643003: Remove app_shell chrome.shell API and ShellAppWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: (remove-shell) rebase 2 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_ 5 #ifndef EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_
6 #define EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_ 6 #define EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_
7 7
8 namespace aura { 8 namespace aura {
9 class Window; 9 class Window;
10 class WindowTreeHost; 10 class WindowTreeHost;
11 } 11 }
12 12
13 namespace content { 13 namespace content {
14 class BrowserContext; 14 class BrowserContext;
15 } 15 }
16 16
17 namespace extensions { 17 namespace extensions {
18 class AppWindow; 18 class AppWindow;
19 class Extension; 19 class Extension;
20 class ShellAppWindow; 20 class ShellAppWindow;
21 21
22 // DesktopController is an interface to construct the window environment in 22 // DesktopController is an interface to construct the window environment in
23 // extensions shell. ShellDesktopController provides a default implementation 23 // extensions shell. ShellDesktopController provides a default implementation
24 // for 24 // for app_shell, and embedder (such as athena) can provide its own.
25 // app_shell, and embedder (such as athena) can provide its own. 25 // TODO(jamescook|oshima): Clean up this interface now that there is only one
26 // way to create an app window.
26 class DesktopController { 27 class DesktopController {
27 public: 28 public:
28 DesktopController(); 29 DesktopController();
29 virtual ~DesktopController(); 30 virtual ~DesktopController();
30 31
31 // Returns the single instance of the desktop. (Stateless functions like 32 // Returns the single instance of the desktop. (Stateless functions like
32 // ShellAppWindowCreateFunction need to be able to access the desktop, so 33 // ShellAppWindowCreateFunction need to be able to access the desktop, so
33 // we need a singleton somewhere). 34 // we need a singleton somewhere).
34 static DesktopController* instance(); 35 static DesktopController* instance();
35 36
36 // Returns the WindowTreeHost created by this DesktopController. 37 // Returns the WindowTreeHost created by this DesktopController.
37 virtual aura::WindowTreeHost* GetHost() = 0; 38 virtual aura::WindowTreeHost* GetHost() = 0;
38 39
39 // Creates a new ShellAppWindow and adds it to the desktop. The desktop
40 // maintains ownership of the window. The window must be closed before
41 // |extension| is destroyed.
42 virtual ShellAppWindow* CreateShellAppWindow(content::BrowserContext* context,
43 const Extension* extension) = 0;
44
45 // Creates a new app window and adds it to the desktop. The desktop maintains 40 // Creates a new app window and adds it to the desktop. The desktop maintains
46 // ownership of the window. The window must be closed before |extension| is 41 // ownership of the window. The window must be closed before |extension| is
47 // destroyed. 42 // destroyed.
48 virtual AppWindow* CreateAppWindow(content::BrowserContext* context, 43 virtual AppWindow* CreateAppWindow(content::BrowserContext* context,
49 const Extension* extension) = 0; 44 const Extension* extension) = 0;
50 45
51 // Attaches the window to our window hierarchy. 46 // Attaches the window to our window hierarchy.
52 virtual void AddAppWindow(aura::Window* window) = 0; 47 virtual void AddAppWindow(aura::Window* window) = 0;
53 48
54 // Closes and destroys the app windows. 49 // Closes and destroys the app windows.
55 virtual void CloseAppWindows() = 0; 50 virtual void CloseAppWindows() = 0;
56 }; 51 };
57 52
58 } // namespace extensinos 53 } // namespace extensions
59 54
60 #endif // EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_ 55 #endif // EXTENSIONS_SHELL_BROWSER_DESKTOP_CONTROLLER_H_
OLDNEW
« no previous file with comments | « extensions/shell/browser/api/shell/shell_api.cc ('k') | extensions/shell/browser/shell_app_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698