Issue 571643002: Enforce that invalidations happen on a rooted tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571643002: Enforce that invalidations happen on a rooted tree (Closed)

Created:
6 years, 3 months ago by Julien - ping for review

Modified:
6 years, 3 months ago

Reviewers:
leviw_travelin_and_unemployed, xianzhanzhu, dsinclair

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Enforce that invalidations happen on a rooted tree Now that most invalidations have moved to after layout, these ASSERTs should not trigger. If they do, we should catch them and fix the callers. This change doesn't touch RenderObject's invalidatePaintForWholeRenderer as it is called when removing a renderer, which can be on an unrooted tree. BUG=368140 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181948