Partial swap implementation for surfaceless

content/browser/compositor/gpu_process_transport_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/compositor/gpu_process_transport_factory.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 222 matching lines @@
 
   scoped_ptr<BrowserCompositorOutputSurface> surface;
 #if defined(USE_OZONE)
   if (ui::SurfaceFactoryOzone::GetInstance()->CanShowPrimaryPlaneAsOverlay()) {
     surface.reset(new GpuSurfacelessBrowserCompositorOutputSurface(
         context_provider,
         per_compositor_data_[compositor]->surface_id,
         &output_surface_map_,
         compositor->vsync_manager(),
         CreateOverlayCandidateValidator(compositor->widget()),
+        GetGLHelper(),

[alexst (slow to review), 2014/09/17 20:34:06]

I don't think this is safe to do. If a context is lost, the helper will get
reset, so you'll be storing a deleted object.

GpuProcessTransportFactory implements ImageTransportFactory, which has a
GetInstance and a getter for GLHelper. We should get the helper directly from
there before each use.

[achaulk, 2014/09/17 20:41:57]

Done.

         GL_RGB8_OES));
   }
 #endif
   if (!surface)
     surface.reset(new GpuBrowserCompositorOutputSurface(
         context_provider,
         per_compositor_data_[compositor]->surface_id,
         &output_surface_map_,
         compositor->vsync_manager(),
         CreateOverlayCandidateValidator(compositor->widget())));
@@ skipping 219 matching lines @@
   FOR_EACH_OBSERVER(ImageTransportFactoryObserver,
                     observer_list_,
                     OnLostResources());
 
   // Kill things that use the shared context before killing the shared context.
   lost_gl_helper.reset();
   lost_shared_main_thread_contexts  = NULL;
 }
 
 }  // namespace content