Convert first letter into a pseudo element.

Source/core/rendering/RenderTextFragment.h

Index: Source/core/rendering/RenderTextFragment.h
diff --git a/Source/core/rendering/RenderTextFragment.h b/Source/core/rendering/RenderTextFragment.h
index 55084b1d72cfbf9b5d3ce501cc10b9e360d12bca..ec742936b4835592ccf6d5fa7aad84c46b2818ad 100644
--- a/Source/core/rendering/RenderTextFragment.h
+++ b/Source/core/rendering/RenderTextFragment.h
@@ -27,6 +27,8 @@
 
 namespace blink {
 
+class FirstLetterPseudoElement;
+
 // Used to represent a text substring of an element, e.g., for text runs that are split because of
 // first letter and that must therefore have different styles (and positions in the render tree).
 // We cache offsets so that text transformations can be applied in such a way that we can recover
@@ -46,11 +48,8 @@ public:
     unsigned end() const { return m_end; }
     virtual unsigned textStartOffset() const override { return start(); }
 
-    RenderBoxModelObject* firstLetter() const { return m_firstLetter; }
-    void setFirstLetter(RenderBoxModelObject* firstLetter) { m_firstLetter = firstLetter; }
-    RenderText* firstRenderTextInFirstLetter() const;
-
     StringImpl* contentString() const { return m_contentString.get(); }
+    PassRefPtr<StringImpl> completeText() const;
     virtual PassRefPtr<StringImpl> originalText() const override;
 
     virtual void setText(PassRefPtr<StringImpl>, bool force = false) override;
@@ -59,20 +58,20 @@ public:
 
     virtual const char* renderName() const override final { return "RenderTextFragment"; }
 
-protected:
-    virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle) override;
+    void setFirstLetterPseudoElement(FirstLetterPseudoElement* element) { m_firstLetterPseudoElement = element; }
+    FirstLetterPseudoElement* firstLetterPseudoElement() const { return m_firstLetterPseudoElement; }
 
 private:
-    virtual void willBeDestroyed() override;
-
-    virtual UChar previousCharacter() const override;
     RenderBlock* blockForAccompanyingFirstLetter() const;
+    virtual UChar previousCharacter() const override;
     virtual void updateHitTestResult(HitTestResult&, const LayoutPoint&) override;

[Julien - ping for review, 2014/10/09 18:24:48]

Unrelated but it's weird that updateHitTestResult can have side effects.

[dsinclair, 2014/10/09 21:14:23]

Acknowledged.

 
+    Text* associatedTextNode() const;
+
     unsigned m_start;
     unsigned m_end;
     RefPtr<StringImpl> m_contentString;
-    RawPtrWillBeMember<RenderBoxModelObject> m_firstLetter;
+    RawPtrWillBeMember<FirstLetterPseudoElement> m_firstLetterPseudoElement;
 };
 
 DEFINE_TYPE_CASTS(RenderTextFragment, RenderObject, object, toRenderText(object)->isTextFragment(), toRenderText(object).isTextFragment());