Source/core/rendering/RenderBlock.h - Issue 571603003: Convert first letter into a pseudo element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 571603003: Convert first letter into a pseudo element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/PseudoElement.cpp ('K') | « Source/core/rendering/HitTestResult.cpp ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | Source/core/rendering/RenderObjectChildList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.h

diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h

index 2a8f1eb8a3286397552de7670a5306eaf2798ba3..9fc4ee453e17cf91dff3fe99fa21505d8abc1d2b 100644

--- a/Source/core/rendering/RenderBlock.h

+++ b/Source/core/rendering/RenderBlock.h

@@ -229,7 +229,6 @@ public:

LayoutUnit collapsedMarginBeforeForChild(const RenderBox* child) const;

LayoutUnit collapsedMarginAfterForChild(const RenderBox* child) const;

- virtual void updateFirstLetter();

virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, HitTestAction) OVERRIDE;

virtual void scrollbarsChanged(bool /*horizontalScrollbarChanged*/, bool /*verticalScrollbarChanged*/) { }

@@ -363,9 +362,6 @@ private:

void insertIntoTrackedRendererMaps(RenderBox* descendant, TrackedDescendantsMap*&, TrackedContainerMap*&);

static void removeFromTrackedRendererMaps(RenderBox* descendant, TrackedDescendantsMap*&, TrackedContainerMap*&);

- void createFirstLetterRenderer(RenderObject* firstLetterBlock, RenderText& currentChild, unsigned length);

- void updateFirstLetterStyle(RenderObject* firstLetterBlock, RenderObject* firstLetterContainer);

Node* nodeForHitTest() const;

private: