Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 571603003: Convert first letter into a pseudo element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/HitTestResult.cpp
diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp
index 921448cb147c49778d173584eb3f12e6a5196feb..b3bb293d5286e755fa6ce8e6c6739b4217ad815d 100644
--- a/Source/core/rendering/HitTestResult.cpp
+++ b/Source/core/rendering/HitTestResult.cpp
@@ -143,7 +143,9 @@ RenderObject* HitTestResult::renderer() const
RenderObject* renderer = m_innerNode->renderer();
if (!m_isFirstLetter || !renderer || !renderer->isText() || !toRenderText(renderer)->isTextFragment())
return renderer;
- return toRenderTextFragment(renderer)->firstRenderTextInFirstLetter();
+
+ // FIXME(dsinclair): First letter renderer
+ ASSERT_NOT_REACHED();
dsinclair 2014/09/27 03:21:21 This doesn't trip on any layout tests. I'm going t
esprehn 2014/09/30 09:00:31 I don't think this can happen now, any hit that wo
dsinclair 2014/09/30 21:46:34 Done. I removed the m_isFirstLetter variable since
}
void HitTestResult::setToShadowHostIfInUserAgentShadowRoot()

Powered by Google App Engine
This is Rietveld 408576698