Convert first letter into a pseudo element.

Source/core/dom/PseudoElement.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 14 matching lines @@
  */
 
 #ifndef PseudoElement_h
 #define PseudoElement_h
 
 #include "core/dom/Element.h"
 #include "core/rendering/style/RenderStyle.h"
 
 namespace blink {
 
-class PseudoElement final : public Element {
+class RenderTextFragment;
+
+class PseudoElement : public Element {
 public:
-    static PassRefPtrWillBeRawPtr<PseudoElement> create(Element* parent, PseudoId pseudoId)
-    {
-        return adoptRefWillBeNoop(new PseudoElement(parent, pseudoId));
-    }
+    static PassRefPtrWillBeRawPtr<PseudoElement> create(Element* parent, PseudoId);
 
     virtual PassRefPtr<RenderStyle> customStyleForRenderer() override;
     virtual void attach(const AttachContext& = AttachContext()) override;
     virtual bool rendererIsNeeded(const RenderStyle&) override;
 
     virtual bool canStartSelection() const override { return false; }
     virtual bool canContainRangeEndPoint() const override { return false; }
     virtual PseudoId pseudoId() const override { return m_pseudoId; }
 
     static String pseudoElementNameForEvents(PseudoId);
 
-    void dispose();
+    virtual void dispose();
+
+protected:
+    PseudoElement(Element*, PseudoId);
 
 private:
-    PseudoElement(Element*, PseudoId);
-
     virtual void didRecalcStyle(StyleRecalcChange) override;
 
     PseudoId m_pseudoId;
 };
 
 const QualifiedName& pseudoElementTagName();
 
 inline bool pseudoElementRendererIsNeeded(const RenderStyle* style)
 {
-    return style && style->display() != NONE && (style->styleType() == BACKDROP || style->contentData());
+    if (!style)
+        return false;
+    if (style->display() == NONE)
+        return false;
+
+    switch (style->styleType()) {
+    case FIRST_LETTER:
+        return true;
+    case BACKDROP:
+        return true;
+    default:

[Julien - ping for review, 2014/10/09 18:24:48]

Let's avoid having a default case as it would allow the compiler to catch adding
more cases.

[dsinclair, 2014/10/09 21:14:22]

There are a lot of these we don't actually care about (there are 21 items in the
PseudoId enum ....) most of which aren't PseudoElements (only first-letter,
backdrop, before and after).

[Julien - ping for review, 2014/10/10 14:47:07]

We looked at this with Dan and having a default with ASSERT_NOT_REACHED()
doesn't work here so it's better to revert to simple if's.

[dsinclair, 2014/10/10 18:06:52]

Done.

+        return style->contentData();
+    }
 }
 
 DEFINE_ELEMENT_TYPE_CASTS(PseudoElement, isPseudoElement());
 
 } // namespace
 
 #endif