Convert first letter into a pseudo element.

Source/core/rendering/RenderTextFragment.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "config.h"
 #include "core/rendering/RenderTextFragment.h"
 
+#include "core/dom/FirstLetterPseudoElement.h"
+#include "core/dom/PseudoElement.h"
+#include "core/dom/StyleChangeReason.h"
 #include "core/dom/Text.h"
 #include "core/rendering/HitTestResult.h"
 #include "core/rendering/RenderBlock.h"
 
 namespace blink {
 
 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str, int startOffset, int length)
     : RenderText(node, str ? str->substring(startOffset, length) : PassRefPtr<StringImpl>(nullptr))
     , m_start(startOffset)
     , m_end(length)
-    , m_firstLetter(nullptr)
+    , m_firstLetterPseudoElement(nullptr)
 {
 }
 
 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str)
     : RenderText(node, str)
     , m_start(0)
     , m_end(str ? str->length() : 0)
     , m_contentString(str)
-    , m_firstLetter(nullptr)
+    , m_firstLetterPseudoElement(nullptr)
 {
 }
 
 RenderTextFragment::~RenderTextFragment()
 {
+    if (m_firstLetterPseudoElement)
+        m_firstLetterPseudoElement->setRemainingTextRenderer(nullptr);
+    m_firstLetterPseudoElement = nullptr;
 }
 
-void RenderTextFragment::trace(Visitor* visitor)
+PassRefPtr<StringImpl> RenderTextFragment::completeText() const
 {
-    visitor->trace(m_firstLetter);
-    RenderText::trace(visitor);
-}
-
-RenderText* RenderTextFragment::firstRenderTextInFirstLetter() const
-{
-    for (RenderObject* current = m_firstLetter; current; current = current->nextInPreOrder(m_firstLetter)) {
-        if (current->isText())
-            return toRenderText(current);
-    }
-    return 0;
+    Text* text = associatedTextNode();
+    return text ? text->dataImpl() : contentString();
 }
 
 PassRefPtr<StringImpl> RenderTextFragment::originalText() const
 {
-    Node* e = node();
-    RefPtr<StringImpl> result = ((e && e->isTextNode()) ? toText(e)->dataImpl() : contentString());
+    RefPtr<StringImpl> result = completeText();
     if (!result)
         return nullptr;
     return result->substring(start(), end());
 }
 
-void RenderTextFragment::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
-{
-    RenderText::styleDidChange(diff, oldStyle);
-
-    if (RenderBlock* block = blockForAccompanyingFirstLetter()) {
-        block->style()->removeCachedPseudoStyle(FIRST_LETTER);
-        block->updateFirstLetter();
-    }
-}
-
-void RenderTextFragment::willBeDestroyed()
-{
-    if (m_firstLetter)
-        m_firstLetter->destroy();
-    RenderText::willBeDestroyed();
-}
-
 void RenderTextFragment::setText(PassRefPtr<StringImpl> text, bool force)
 {
     RenderText::setText(text, force);
 
     m_start = 0;
     m_end = textLength();
-    if (m_firstLetter) {
-        // FIXME: We should not modify the structure of the render tree during
-        // layout. crbug.com/370458
-        DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
 
-        ASSERT(!m_contentString);
-        m_firstLetter->destroy();
-        m_firstLetter = nullptr;
-        if (Node* t = node()) {
-            ASSERT(!t->renderer());
-            t->setRenderer(this);
-        }
+    // If we're the remaining text from a first letter then we have to tell the
+    // first letter pseudo element to reattach itself so it can re-calculate the
+    // correct first-letter settings.
+    if (RenderObject* previous = previousSibling()) {
+        if (!previous->isPseudoElement() || !previous->node()->isFirstLetterPseudoElement())
+            return;
+
+        // Tell the first letter container node, and the first-letter node
+        // that their style may have changed.
+        // e.g. fast/css/first-letter-detach.html
+        toFirstLetterPseudoElement(previous->node())->setIsStale();

[esprehn, 2014/10/07 00:17:40]

setIsStale() should probably be something like setNeedsUpdate() and it should
schedule the style recalc.

[dsinclair, 2014/10/07 19:36:21]

Done.

+        if (document().lifecycle().state() != DocumentLifecycle::InStyleRecalc)
+            document().setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::PseudoClass));

[esprehn, 2014/10/07 00:17:40]

This is definitely not right, you're causing a _full document_ forced style
recalc!

[dsinclair, 2014/10/07 19:36:21]

How do I tell the system that it needs to run style recalc or certain nodes?
This worked, but as you said, is triggering a full recalc.

I tried document().updateRenderTreeIfNeeded() and
document().updateLayoutIgnorePendingStylesheets() but neither of those did the
trick.

     }
 }
 
 void RenderTextFragment::transformText()
 {
-    // Don't reset first-letter here because we are only transforming the truncated fragment.

[Julien - ping for review, 2014/10/06 17:47:33]

Doesn't this comment still applies?

[dsinclair, 2014/10/07 19:36:21]

Done.

     if (RefPtr<StringImpl> textToTransform = originalText())
         RenderText::setText(textToTransform.release(), true);
 }
 
 UChar RenderTextFragment::previousCharacter() const
 {
     if (start()) {
-        Node* e = node();
-        StringImpl* original = ((e && e->isTextNode()) ? toText(e)->dataImpl() : contentString());
+        StringImpl* original = completeText().get();
         if (original && start() <= original->length())
             return (*original)[start() - 1];
     }
 
     return RenderText::previousCharacter();
 }
 
-RenderBlock* RenderTextFragment::blockForAccompanyingFirstLetter() const
-{
-    if (!m_firstLetter)
-        return 0;
-    for (RenderObject* block = m_firstLetter->parent(); block; block = block->parent()) {
-        if (block->style()->hasPseudoStyle(FIRST_LETTER) && block->canHaveChildren() && block->isRenderBlock())
-            return toRenderBlock(block);
-    }
-    return 0;
-}
-
 void RenderTextFragment::updateHitTestResult(HitTestResult& result, const LayoutPoint& point)
 {
     if (result.innerNode())
         return;
 
     RenderObject::updateHitTestResult(result, point);
-    if (m_firstLetter || !node())
-        return;
-    RenderObject* nodeRenderer = node()->renderer();
-    if (!nodeRenderer || !nodeRenderer->isText() || !toRenderText(nodeRenderer)->isTextFragment())
+    if (!node())
         return;
 
-    if (isDescendantOf(toRenderTextFragment(nodeRenderer)->m_firstLetter))
-        result.setIsFirstLetter(true);
+    // FIXME(dsinclair): First letter?

[Julien - ping for review, 2014/10/06 17:47:33]

Let's put an actionable FIXME, preferably with a bug.

[dsinclair, 2014/10/07 19:36:21]

Leftover from when I was cutting things out, removed.

 }
 
+// If this is the renderer for a first-letter pseudoNode then we have to look
+// at the node for the remaining text to find our content.
+Text* RenderTextFragment::associatedTextNode() const
+{
+    Node* node = this->node();
+    if (!node)
+        return nullptr;
+
+    if (node->isFirstLetterPseudoElement()) {
+        PseudoElement* pseudo = toPseudoElement(node);
+        RenderObject* nextRenderer = FirstLetterPseudoElement::firstLetterTextRenderer(*pseudo);
+        if (!nextRenderer)
+            return nullptr;
+        node = nextRenderer->node();
+    }
+    return (node && node->isTextNode()) ? toText(node) : nullptr;
+}
+
+

[Julien - ping for review, 2014/10/06 17:47:33]

Unneeded space to be removed.

[dsinclair, 2014/10/07 19:36:21]

Done.

 } // namespace blink