Convert first letter into a pseudo element.

Source/core/dom/PseudoElement.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 14 matching lines @@
  */
 
 #ifndef PseudoElement_h
 #define PseudoElement_h
 
 #include "core/dom/Element.h"
 #include "core/rendering/style/RenderStyle.h"
 
 namespace blink {
 
-class PseudoElement FINAL : public Element {
+class RenderTextFragment;
+
+class PseudoElement : public Element {
 public:
-    static PassRefPtrWillBeRawPtr<PseudoElement> create(Element* parent, PseudoId pseudoId)
-    {
-        return adoptRefWillBeNoop(new PseudoElement(parent, pseudoId));
-    }
+    static PassRefPtrWillBeRawPtr<PseudoElement> create(Element* parent, PseudoId);
 
     virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;
     virtual void attach(const AttachContext& = AttachContext()) OVERRIDE;
     virtual bool rendererIsNeeded(const RenderStyle&) OVERRIDE;
 
     virtual bool canStartSelection() const OVERRIDE { return false; }
     virtual bool canContainRangeEndPoint() const OVERRIDE { return false; }
     virtual PseudoId pseudoId() const OVERRIDE { return m_pseudoId; }
 
     static String pseudoElementNameForEvents(PseudoId);
 
-    void dispose();
+    virtual void dispose();
 
 private:
+    friend class FirstLetterPseudoElement; // For constructor.

[Julien - ping for review, 2014/10/06 17:47:33]

Let's make the constructor protected instead of a blanket friend declaration.

[dsinclair, 2014/10/07 19:36:21]

Done.

+
     PseudoElement(Element*, PseudoId);
 
     virtual void didRecalcStyle(StyleRecalcChange) OVERRIDE;
 
     PseudoId m_pseudoId;
 };
 
 const QualifiedName& pseudoElementTagName();
 
 inline bool pseudoElementRendererIsNeeded(const RenderStyle* style)
 {
-    return style && style->display() != NONE && (style->styleType() == BACKDROP || style->contentData());
+    if (!style)
+        return false;
+    if (style->display() == NONE)
+        return false;
+    if (style->styleType() == FIRST_LETTER)
+        return true;
+    if (style->styleType() == BACKDROP)

[esprehn, 2014/10/07 00:17:40]

I would just || the two style types together.

[dsinclair, 2014/10/07 19:36:21]

Went with the switch route.

+        return true;
+    if (style->contentData())
+        return true;
+    return false;

[Julien - ping for review, 2014/10/06 17:47:33]

This past 3 lines can be simplified to:

return style->contentData();

[dsinclair, 2014/10/07 19:36:21]

Done.

 }

[Julien - ping for review, 2014/10/06 17:47:33]

It seems like a switch on styleType() would make this code more readable as the
code was doing implicit casing.

[dsinclair, 2014/10/07 19:36:21]

Done.

 
 DEFINE_ELEMENT_TYPE_CASTS(PseudoElement, isPseudoElement());
 
 } // namespace
 
 #endif