Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: Source/core/rendering/RenderTextFragment.cpp

Issue 571603003: Convert first letter into a pseudo element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Dirk Mueller (mueller@kde.org) 3 * (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 * 20 *
21 */ 21 */
22 22
23 #include "config.h" 23 #include "config.h"
24 #include "core/rendering/RenderTextFragment.h" 24 #include "core/rendering/RenderTextFragment.h"
25 25
26 #include "core/dom/FirstLetterHelper.h"
27 #include "core/dom/PseudoElement.h"
28 #include "core/dom/StyleChangeReason.h"
26 #include "core/dom/Text.h" 29 #include "core/dom/Text.h"
27 #include "core/rendering/HitTestResult.h" 30 #include "core/rendering/HitTestResult.h"
28 #include "core/rendering/RenderBlock.h" 31 #include "core/rendering/RenderBlock.h"
29 32
30 namespace blink { 33 namespace blink {
31 34
32 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str, int startOff set, int length) 35 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str, int startOff set, int length)
33 : RenderText(node, str ? str->substring(startOffset, length) : PassRefPtr<St ringImpl>(nullptr)) 36 : RenderText(node, str ? str->substring(startOffset, length) : PassRefPtr<St ringImpl>(nullptr))
34 , m_start(startOffset) 37 , m_start(startOffset)
35 , m_end(length) 38 , m_end(length)
36 , m_firstLetter(nullptr)
37 { 39 {
38 } 40 }
39 41
40 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str) 42 RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str)
41 : RenderText(node, str) 43 : RenderText(node, str)
42 , m_start(0) 44 , m_start(0)
43 , m_end(str ? str->length() : 0) 45 , m_end(str ? str->length() : 0)
44 , m_contentString(str) 46 , m_contentString(str)
45 , m_firstLetter(nullptr)
46 { 47 {
47 } 48 }
48 49
49 RenderTextFragment::~RenderTextFragment() 50 RenderTextFragment::~RenderTextFragment()
50 { 51 {
51 } 52 }
52 53
53 void RenderTextFragment::trace(Visitor* visitor) 54 PassRefPtr<StringImpl> RenderTextFragment::completeText() const
54 { 55 {
55 visitor->trace(m_firstLetter); 56 Text* text = associatedTextNode();
56 RenderText::trace(visitor); 57 return text ? text->dataImpl() : contentString();
57 }
58
59 RenderText* RenderTextFragment::firstRenderTextInFirstLetter() const
60 {
61 for (RenderObject* current = m_firstLetter; current; current = current->next InPreOrder(m_firstLetter)) {
62 if (current->isText())
63 return toRenderText(current);
64 }
65 return 0;
66 } 58 }
67 59
68 PassRefPtr<StringImpl> RenderTextFragment::originalText() const 60 PassRefPtr<StringImpl> RenderTextFragment::originalText() const
69 { 61 {
70 Node* e = node(); 62 RefPtr<StringImpl> result = completeText();
71 RefPtr<StringImpl> result = ((e && e->isTextNode()) ? toText(e)->dataImpl() : contentString());
72 if (!result) 63 if (!result)
73 return nullptr; 64 return nullptr;
74 return result->substring(start(), end()); 65 return result->substring(start(), end());
75 } 66 }
76 67
77 void RenderTextFragment::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
78 {
79 RenderText::styleDidChange(diff, oldStyle);
80
81 if (RenderBlock* block = blockForAccompanyingFirstLetter()) {
82 block->style()->removeCachedPseudoStyle(FIRST_LETTER);
83 block->updateFirstLetter();
84 }
85 }
86
87 void RenderTextFragment::willBeDestroyed()
88 {
89 if (m_firstLetter)
90 m_firstLetter->destroy();
91 RenderText::willBeDestroyed();
92 }
93
94 void RenderTextFragment::setText(PassRefPtr<StringImpl> text, bool force) 68 void RenderTextFragment::setText(PassRefPtr<StringImpl> text, bool force)
95 { 69 {
96 RenderText::setText(text, force); 70 RenderText::setText(text, force);
97 71
98 m_start = 0; 72 m_start = 0;
99 m_end = textLength(); 73 m_end = textLength();
100 if (m_firstLetter) {
101 // FIXME: We should not modify the structure of the render tree during
102 // layout. crbug.com/370458
103 DeprecatedDisableModifyRenderTreeStructureAsserts disabler;
104 74
105 ASSERT(!m_contentString); 75 // If we're the remaining text from a first letter then we have to tell the
106 m_firstLetter->destroy(); 76 // first letter pseudo element to reattach itself so it can re-calculate the
107 m_firstLetter = nullptr; 77 // correct first-letter settings.
108 if (Node* t = node()) { 78 if (RenderObject* previous = previousSibling()) {
109 ASSERT(!t->renderer()); 79 if (!previous->isPseudoElement() || !previous->node()->isFirstLetterPseu doElement())
110 t->setRenderer(this); 80 return;
111 } 81
82 // Tell the first letter container node, and the first-letter node
83 // that their style may have changed.
84 // e.g. fast/css/first-letter-detach.html
85 previous->node()->setNeedsStyleRecalc(LocalStyleChange, StyleChangeReaso nForTracing::create(StyleChangeReason::PseudoClass));
86 previous->node()->parentElement()->setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::PseudoClass));
87
88 // FIXME:: Will this get cleaned up properly? OR am I leaking here?
89 previous->node()->detach();
Julien - ping for review 2014/10/01 21:14:47 It's interesting that detach doesn't trigger the d
dsinclair 2014/10/04 02:01:34 Done. This should be cleaned up when we do the rec
112 } 90 }
113 } 91 }
114 92
115 void RenderTextFragment::transformText() 93 void RenderTextFragment::transformText()
116 { 94 {
117 // Don't reset first-letter here because we are only transforming the trunca ted fragment.
118 if (RefPtr<StringImpl> textToTransform = originalText()) 95 if (RefPtr<StringImpl> textToTransform = originalText())
119 RenderText::setText(textToTransform.release(), true); 96 RenderText::setText(textToTransform.release(), true);
120 } 97 }
121 98
122 UChar RenderTextFragment::previousCharacter() const 99 UChar RenderTextFragment::previousCharacter() const
123 { 100 {
124 if (start()) { 101 if (start()) {
125 Node* e = node(); 102 StringImpl* original = completeText().get();
126 StringImpl* original = ((e && e->isTextNode()) ? toText(e)->dataImpl() : contentString());
127 if (original && start() <= original->length()) 103 if (original && start() <= original->length())
128 return (*original)[start() - 1]; 104 return (*original)[start() - 1];
129 } 105 }
130 106
131 return RenderText::previousCharacter(); 107 return RenderText::previousCharacter();
132 } 108 }
133 109
134 RenderBlock* RenderTextFragment::blockForAccompanyingFirstLetter() const
135 {
136 if (!m_firstLetter)
137 return 0;
138 for (RenderObject* block = m_firstLetter->parent(); block; block = block->pa rent()) {
139 if (block->style()->hasPseudoStyle(FIRST_LETTER) && block->canHaveChildr en() && block->isRenderBlock())
140 return toRenderBlock(block);
141 }
142 return 0;
143 }
144
145 void RenderTextFragment::updateHitTestResult(HitTestResult& result, const Layout Point& point) 110 void RenderTextFragment::updateHitTestResult(HitTestResult& result, const Layout Point& point)
146 { 111 {
147 if (result.innerNode()) 112 if (result.innerNode())
148 return; 113 return;
149 114
150 RenderObject::updateHitTestResult(result, point); 115 RenderObject::updateHitTestResult(result, point);
151 if (m_firstLetter || !node()) 116 if (!node())
152 return;
153 RenderObject* nodeRenderer = node()->renderer();
154 if (!nodeRenderer || !nodeRenderer->isText() || !toRenderText(nodeRenderer)- >isTextFragment())
155 return; 117 return;
156 118
157 if (isDescendantOf(toRenderTextFragment(nodeRenderer)->m_firstLetter)) 119 // FIXME(dsinclair): First letter?
158 result.setIsFirstLetter(true);
159 } 120 }
160 121
122 // If this is the renderer for a first-letter pseudoNode then we have to look
123 // at the node for the remaining text to find our content.
124 Text* RenderTextFragment::associatedTextNode() const
125 {
126 Node* node = this->node();
127 if (!node)
128 return nullptr;
129
130 if (node->isFirstLetterPseudoElement()) {
131 PseudoElement* pseudo = toPseudoElement(node);
132 RenderObject* nextRenderer = FirstLetterHelper::firstLetterTextRenderer( *pseudo);
133 if (!nextRenderer)
134 return nullptr;
135 node = nextRenderer->node();
136 }
137 return (node && node->isTextNode()) ? toText(node) : nullptr;
138 }
139
140
161 } // namespace blink 141 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698