LayoutTests/fast/css/dynamic-class-pseudo-elements.html - Issue 571603003: Convert first letter into a pseudo element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/dynamic-class-pseudo-elements.html

Issue 571603003: Convert first letter into a pseudo element. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/css/dynamic-class-pseudo-elements-expected.txt » ('j') | Source/core/dom/Element.cpp » ('J')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <style>	3 <style>

4 .a1 .b1::before { background-color: green; content: "X" }	4 .a1 .b1::before { background-color: green; content: "X" }

5 .a2 .b2::after { background-color: green; content: "X" }	5 .a2 .b2::after { background-color: green; content: "X" }

6 .a3 .b3::first-line { background-color: green }	6 .a3 .b3::first-line { background-color: green }

7 .a4 .b4::first-letter { background-color: green }	7 .a4 .b4::first-letter { background-color: green }

8	8

9 /* workaround for issue 351322 */	9 /* workaround for issue 351322 */

10 .b3::first-line { background-color: transparent }	10 .b3::first-line { background-color: transparent }

(...skipping 63 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
74 shouldBe("getComputedStyle(r3, '::first-line').backgroundColor", "green");	74 shouldBe("getComputedStyle(r3, '::first-line').backgroundColor", "green");

75	75

76 var t4 = document.getElementById("t4");	76 var t4 = document.getElementById("t4");

77 var r4 = document.getElementById("r4");	77 var r4 = document.getElementById("r4");

78 shouldBe("getComputedStyle(r4, '::first-letter').backgroundColor", "transparent" );	78 shouldBe("getComputedStyle(r4, '::first-letter').backgroundColor", "transparent" );

79	79

80 forceLayout();	80 forceLayout();

81 t4.className = "a4";	81 t4.className = "a4";

82	82

83 if (window.internals)	83 if (window.internals)

84 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "8");	84 shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "10");
	dsinclair 2014/09/27 03:21:21 What does this check do? I'm not sure why the numb What does this check do? I'm not sure why the number went up, but I also don't understand where the number came from? esprehn 2014/09/30 09:00:29 It's the number of Element instances that went thr Show quoted text On 2014/09/27 at 03:21:21, dsinclair wrote: > What does this check do? I'm not sure why the number went up, but I also don't understand where the number came from? It's the number of Element instances that went through ::recalcStyle(). So you're causing 2 more elements to go through recalcStyle in this test. Given the number of first letters, is that correct?
85	85

86 document.body.offsetLeft; // workaround for issue 351308	86 document.body.offsetLeft; // workaround for issue 351308

87 shouldBe("getComputedStyle(r4, '::first-letter').backgroundColor", "green");	87 shouldBe("getComputedStyle(r4, '::first-letter').backgroundColor", "green");

88 </script>	88 </script>

OLD	NEW