Convert first letter into a pseudo element.

Source/core/dom/RenderTreeBuilder.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef RenderTreeBuilder_h
 #define RenderTreeBuilder_h
 
 #include "core/dom/Document.h"
+#include "core/dom/FirstLetterPseudoElement.h"
 #include "core/dom/Node.h"
 #include "core/dom/NodeRenderingTraversal.h"
+#include "core/rendering/RenderObject.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class ContainerNode;
-class RenderObject;
 class RenderStyle;
 
 class RenderTreeBuilder {
     STACK_ALLOCATED();
 public:
     RenderTreeBuilder(Node* node, RenderStyle* style)
         : m_node(node)
         , m_renderingParent(nullptr)
         , m_style(style)
     {
         ASSERT(!node->renderer());
         ASSERT(node->needsAttach());
         ASSERT(node->document().inStyleRecalc());
 
         // FIXME: We should be able to ASSERT(node->inActiveDocument()) but childrenChanged is called
         // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
         // will trigger a layout inside childrenChanged.
         // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControlElement::setSelectionRange
         // which does an updateLayoutIgnorePendingStylesheets.
 
-        m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetails);
+        Element* element = node->isElementNode() ? toElement(node) : 0;
+        if (element && element->isFirstLetterPseudoElement()) {
+            RenderObject* nextRenderer = FirstLetterPseudoElement::firstLetterTextRenderer(*element);
+            if (nextRenderer && nextRenderer->parent())

[esprehn, 2014/10/11 04:46:20]

This should not be inline, this is way too much code to have in the inline
constructor.

[dsinclair, 2014/10/14 14:31:27]

Done.

+                m_renderingParent = nextRenderer->parent();

[esprehn, 2014/10/11 04:46:20]

m_renderingParent is nullptr either way, so you can just do

if (nextRenderer)
  m_renderingParent = nextRenderer->parent();

you don't need to null check it first.

[dsinclair, 2014/10/14 14:31:27]

Done.

+
+        } else {
+            ContainerNode* containerNode = NodeRenderingTraversal::parent(node, &m_parentDetails);

[esprehn, 2014/10/11 04:46:20]

else if (ContainerNode* ...)

[dsinclair, 2014/10/14 14:31:27]

Done.

+            if (containerNode)
+                m_renderingParent = containerNode->renderer();
+        }
     }
 
     void createRendererForTextIfNeeded();
     void createRendererForElementIfNeeded();
 
 private:
     RenderObject* parentRenderer() const;
     RenderObject* nextRenderer() const;
     bool shouldCreateRenderer() const;
     RenderStyle& style() const;
 
     RawPtrWillBeMember<Node> m_node;
-    RawPtrWillBeMember<ContainerNode> m_renderingParent;
+    RawPtrWillBeMember<RenderObject> m_renderingParent;

[Julien - ping for review, 2014/10/10 22:47:23]

I would have liked this change to be in a separate refactoring. I also wonder if
m_renderingParentRenderer would be better but that's orthogonal.

[esprehn, 2014/10/11 04:46:20]

Hmm, this seems bad. The parent is always supposed to have a node(). I guess we
can try to iron this out later.

[dsinclair, 2014/10/14 14:31:27]

Acknowledged.

[dsinclair, 2014/10/14 14:31:27]

So, the problem I have specifically, is if you have a :before and a
:first-letter, the parent renderer of the first element is an anonymous renderer
generated by the :before. So, that anonymous renderer doesn't have a node but we
need that renderer to attach the first letter renderer too.

     NodeRenderingTraversal::ParentDetails m_parentDetails;
     mutable RefPtr<RenderStyle> m_style;
 };
 
 } // namespace blink
 
 #endif