Chromium Code Reviews
Help | Chromium Project | Sign in
(139)

Issue 5716001: Add gyp target to build preparser as stand-alone library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Lasse Reichstein
Modified:
4 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Add gyp target to build preparser as stand-alone library. Likely only works on Linux yet.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments. #

Patch Set 3 : Add type field for static windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -152 lines) Patch
M src/ast.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +6 lines, -19 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 chunks +10 lines, -14 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime-profiler.cc View 1 6 chunks +14 lines, -77 lines 0 comments Download
M src/v8natives.js View 1 1 chunk +1 line, -7 lines 0 comments Download
A src/v8preparserdll-main.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/mjsunit/object-define-property.js View 1 1 chunk +0 lines, -32 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
4 years, 7 months ago (2010-12-09 13:43:46 UTC) #1
Søren Thygesen Gjesse
LGTM, but I think you should try it in chromium to trin away the options ...
4 years, 7 months ago (2010-12-09 14:08:00 UTC) #2
Søren Thygesen Gjesse
On 2010/12/09 14:08:00, Søren Gjesse wrote: > LGTM, > > but I think you should ...
4 years, 7 months ago (2010-12-10 09:10:42 UTC) #3
Lasse Reichstein
4 years, 7 months ago (2010-12-13 09:19:49 UTC) #4
http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode33
tools/gyp/v8.gyp:33: 'host_arch%': '<(target_arch)',
Removed.

http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode200
tools/gyp/v8.gyp:200: 'target_name': 'v8-preparser',
On 2010/12/09 14:08:00, Søren Gjesse wrote:
> - -> _, other targets use underscore.

Done.

http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode227
tools/gyp/v8.gyp:227: ['OS=="linux" and library=="shared_library"', {
On 2010/12/09 14:08:00, Søren Gjesse wrote:
> I also think -fPIC should be provided by the consumer of v8.gyp. We don't set
> -fPIC for any other targets in this file.

Done.

http://codereview.chromium.org/5716001/diff/1/tools/gyp/v8.gyp#newcode230
tools/gyp/v8.gyp:230: ['v8_target_arch!="x64" and host_arch=="x64"', {
Removed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5