Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 571533004: One missed #ifdef and some comments cleaned up. (Closed)

Created:
6 years, 3 months ago by Jana
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ycheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

One missed #ifdef and some comments cleaned up. BUG=402005 Committed: https://crrev.com/23fdae2acd89612f5198651e51c5aa7557667a2b Cr-Commit-Position: refs/heads/master@{#295171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M net/socket/tcp_socket_libevent.h View 1 chunk +11 lines, -11 lines 0 comments Download
M net/socket/tcp_socket_libevent.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Jana
Tiny CL.
6 years, 3 months ago (2014-09-16 19:45:30 UTC) #2
Randy Smith (Not in Mondays)
lgtm
6 years, 3 months ago (2014-09-16 19:52:20 UTC) #3
mmenke
On 2014/09/16 19:52:20, rdsmith wrote: > lgtm LGTM
6 years, 3 months ago (2014-09-16 21:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571533004/1
6 years, 3 months ago (2014-09-16 21:39:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/16123)
6 years, 3 months ago (2014-09-16 21:51:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571533004/1
6 years, 3 months ago (2014-09-16 21:55:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3d692fc929b2b94580f0b5566570565ecbf5d6a6
6 years, 3 months ago (2014-09-16 23:04:22 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 23:05:10 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/23fdae2acd89612f5198651e51c5aa7557667a2b
Cr-Commit-Position: refs/heads/master@{#295171}

Powered by Google App Engine
This is Rietveld 408576698