Mac: Add support for in-process crash reporting

common/mac/launch_reporter.cc

-// Copyright (c) 2007, Google Inc.
+// Copyright (c) 2014, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 // copyright notice, this list of conditions and the following disclaimer
 // in the documentation and/or other materials provided with the
 // distribution.
 //     * Neither the name of Google Inc. nor the names of its
 // contributors may be used to endorse or promote products derived from
 // this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-//
-// Main driver for Inspector
 
-#import "client/mac/crash_generation/Inspector.h"
-#import <Cocoa/Cocoa.h>
+#include <sys/wait.h>
+#include <unistd.h>
 
 namespace google_breakpad {
 
-//=============================================================================
-extern "C" {
+void LaunchReporter(const char *reporterExecutablePath,
+                    const char *configFilePath) {
+                    const char *argv[3];

[Mark Mentovai, 2014/09/12 21:58:21]

Don’t line this up with the parameters: that makes it look like a parameter too.

const char* argv[] = { reporterExecutablePath, configFilePath, NULL }; is a
little cleaner than this, too.

[Andre, 2014/09/12 22:59:40]

Done.

+  argv[0] = reporterExecutablePath;
+  argv[1] = configFilePath;
+  argv[2] = NULL;
 
-int main(int argc, char *const argv[]) {
-#if DEBUG
-  // Since we're launched on-demand, this is necessary to see debugging
-  // output in the console window.
-  freopen("/dev/console", "w", stdout);
-  freopen("/dev/console", "w", stderr);
-#endif
+  // Launch the reporter
+  pid_t pid = fork();
 
-  NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+  // If we're in the child, load in our new executable and run.
+  // The parent will not wait for the child to complete.
+  if (pid == 0) {
+    execv(argv[0], (char * const *)argv);
+    unlink(configFilePath);  // launch failed - get rid of config file

[Mark Mentovai, 2014/09/12 21:58:21]

fprintf something to stderr here about exec’s failure, too?

[Andre, 2014/09/12 22:59:40]

Done.

+    _exit(1);
+  }
 
-  if (argc != 2) {
-    exit(0);
+  // Wait until the Reporter child process exits.
+  //
+
+  // We'll use a timeout of one minute.
+  int timeoutCount = 60;   // 60 seconds
+
+  while (timeoutCount-- > 0) {
+    int status;
+    pid_t result = waitpid(pid, &status, WNOHANG);

[Mark Mentovai, 2014/09/12 21:58:21]

I know that this is old code that you’re just moving, but it’s kind of weird…but
since it’s old code, I guess it’s all right. We’re not looking to reinvent the
world here.

[Andre, 2014/09/12 22:59:40]

Acknowledged.

+
+    if (result == 0) {
+      // The child has not yet finished.
+      sleep(1);
+    } else if (result == -1) {
+      // error occurred.
+      break;
+    } else {
+      // child has finished
+      break;
+    }
   }
-  // Our first command-line argument contains the name of the service
-  // that we're providing.
-  google_breakpad::Inspector inspector;
-  inspector.Inspect(argv[1]);
-
-  [pool release];
-
-  return 0;
 }
 
-} // extern "C"
-
 } // namespace google_breakpad