Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 5714001: Improve our type feedback by recogizining never-executed IC calls for binary ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: address comments, fixed ARM build. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 LPointerMap* pointers = instr->pointer_map(); 308 LPointerMap* pointers = instr->pointer_map();
309 RecordPosition(pointers->position()); 309 RecordPosition(pointers->position());
310 __ call(code, mode); 310 __ call(code, mode);
311 RegisterLazyDeoptimization(instr); 311 RegisterLazyDeoptimization(instr);
312 } else { 312 } else {
313 LPointerMap no_pointers(0); 313 LPointerMap no_pointers(0);
314 RecordPosition(no_pointers.position()); 314 RecordPosition(no_pointers.position());
315 __ call(code, mode); 315 __ call(code, mode);
316 RecordSafepoint(&no_pointers, Safepoint::kNoDeoptimizationIndex); 316 RecordSafepoint(&no_pointers, Safepoint::kNoDeoptimizationIndex);
317 } 317 }
318
319 // Signal that we don't inline smi code before these stubs in the
320 // optimizing code generator.
321 if (code->kind() == Code::TYPE_RECORDING_BINARY_OP_IC ||
322 code->kind() == Code::COMPARE_IC) {
323 __ nop();
324 }
318 } 325 }
319 326
320 327
321 void LCodeGen::CallRuntime(Runtime::Function* function, 328 void LCodeGen::CallRuntime(Runtime::Function* function,
322 int num_arguments, 329 int num_arguments,
323 LInstruction* instr) { 330 LInstruction* instr) {
324 ASSERT(instr != NULL); 331 ASSERT(instr != NULL);
325 LPointerMap* pointers = instr->pointer_map(); 332 LPointerMap* pointers = instr->pointer_map();
326 ASSERT(pointers != NULL); 333 ASSERT(pointers != NULL);
327 RecordPosition(pointers->position()); 334 RecordPosition(pointers->position());
(...skipping 2827 matching lines...) Expand 10 before | Expand all | Expand 10 after
3155 ASSERT(!environment->HasBeenRegistered()); 3162 ASSERT(!environment->HasBeenRegistered());
3156 RegisterEnvironmentForDeoptimization(environment); 3163 RegisterEnvironmentForDeoptimization(environment);
3157 ASSERT(osr_pc_offset_ == -1); 3164 ASSERT(osr_pc_offset_ == -1);
3158 osr_pc_offset_ = masm()->pc_offset(); 3165 osr_pc_offset_ = masm()->pc_offset();
3159 } 3166 }
3160 3167
3161 3168
3162 #undef __ 3169 #undef __
3163 3170
3164 } } // namespace v8::internal 3171 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698