Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 571373002: mojo: Add isolate test for python bindings test (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Add isolate test for python bindings test R=yzshen@chromium.org Committed: https://crrev.com/e16a8443f81847b5a383dedfdc699367d344d665 Cr-Commit-Position: refs/heads/master@{#295093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M mojo/mojo.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A mojo/mojo_python_unittests.isolate View 1 chunk +24 lines, -0 lines 0 comments Download
M mojo/tools/pylib/mojo_python_tests_runner.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
qsr
6 years, 3 months ago (2014-09-16 11:09:04 UTC) #1
yzshen1
lgtm
6 years, 3 months ago (2014-09-16 16:26:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571373002/1
6 years, 3 months ago (2014-09-16 16:29:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 834ac68f896bfd3cd7dcadad1e442c4e36e9b145
6 years, 3 months ago (2014-09-16 17:29:58 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 17:31:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16a8443f81847b5a383dedfdc699367d344d665
Cr-Commit-Position: refs/heads/master@{#295093}

Powered by Google App Engine
This is Rietveld 408576698