Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 571353002: mojo: Starting serialization for python bindings. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Starting serialization for python bindings. This is a reland of https://codereview.chromium.org/570563002 with the gyp build config updated. R=sdefresne@chromium.org Committed: https://crrev.com/08fb34f917c8e84c0ad94e326b8ae9e81c5d3d90 Cr-Commit-Position: refs/heads/master@{#295038}

Patch Set 1 #

Patch Set 2 : Update gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+519 lines, -104 lines) Patch
M mojo/mojo.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/python/mojo/bindings/descriptor.py View 10 chunks +266 lines, -47 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 2 chunks +17 lines, -1 line 0 comments Download
A mojo/public/python/mojo/bindings/serialization.py View 1 chunk +98 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 4 chunks +81 lines, -53 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/python/tests/bindings_serialization_deserialization_unittest.py View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
qsr
The change from the reverted version is in the gyp file.
6 years, 3 months ago (2014-09-16 08:46:58 UTC) #1
sdefresne
lgtm
6 years, 3 months ago (2014-09-16 08:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571353002/20001
6 years, 3 months ago (2014-09-16 09:22:12 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 60f5ced1ac7e763669d0d15f6134a6b01352ae12
6 years, 3 months ago (2014-09-16 10:21:06 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 10:22:21 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/08fb34f917c8e84c0ad94e326b8ae9e81c5d3d90
Cr-Commit-Position: refs/heads/master@{#295038}

Powered by Google App Engine
This is Rietveld 408576698