Add notification before getMultiProfileShareEntries_.

ui/file_manager/file_manager/foreground/js/file_transfer_controller.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Global (placed in the window object) variable name to hold internal
  * file dragging information. Needed to show visual feedback while dragging
  * since DataTransfer object is in protected state. Reachable from other
  * file manager instances.
  */
 var DRAG_AND_DROP_GLOBAL_DATA = '__drag_and_drop_global_data';
 
 /**
  * @param {HTMLDocument} doc Owning document.
  * @param {FileOperationManager} fileOperationManager File operation manager
  *     instance.
  * @param {MetadataCache} metadataCache Metadata cache service.
  * @param {DirectoryModel} directoryModel Directory model instance.
  * @param {VolumeManagerWrapper} volumeManager Volume manager instance.
  * @param {MultiProfileShareDialog} multiProfileShareDialog Share dialog to be
  *     used to share files from another profile.

[hirono, 2014/09/16 08:12:56]

Please update JSDoc.

[iseki, 2014/09/16 08:44:21]

Done.

  * @constructor
  */
 function FileTransferController(doc,
                                 fileOperationManager,
                                 metadataCache,
                                 directoryModel,
                                 volumeManager,
-                                multiProfileShareDialog) {
+                                multiProfileShareDialog,
+                                progressCenter) {
   this.document_ = doc;
   this.fileOperationManager_ = fileOperationManager;
   this.metadataCache_ = metadataCache;
   this.directoryModel_ = directoryModel;
   this.volumeManager_ = volumeManager;
   this.multiProfileShareDialog_ = multiProfileShareDialog;
+  this.progressCenter_ = progressCenter;
 
   this.directoryModel_.getFileList().addEventListener(
       'change', function(event) {
     if (this.directoryModel_.getFileListSelection().
         getIndexSelected(event.index)) {
       this.onSelectionChanged_();
     }
   }.bind(this));
   this.directoryModel_.getFileListSelection().addEventListener('change',
       this.onSelectionChanged_.bind(this));
 
   /**
+   * The array of pending task id.
+   * @type {Array.<string>}
+   */
+  this.pendingTaskId = [];

[hirono, 2014/09/16 08:12:56]

nit: pendingTaskIDs ?

[iseki, 2014/09/16 08:44:21]

Done.

+
+  /**
    * Promise to be fulfilled with the thumbnail image of selected file in drag
    * operation. Used if only one element is selected.
    * @type {Promise}
    * @private
    */
   this.preloadedThumbnailImagePromise_ = null;
 
   /**
    * File objects for selected files.
    *
    * @type {Array.<File>}
    * @private
    */
   this.selectedFileObjects_ = [];
 
   /**
    * Drag selector.
    * @type {DragSelector}
    * @private
    */
   this.dragSelector_ = new DragSelector();
 
   /**
    * Whether a user is touching the device or not.
    * @type {boolean}
    * @private
    */
   this.touching_ = false;
+
+  /**
+   * Task id counter.
+   * @type {int}

[hirono, 2014/09/16 08:12:56]

We don't use int. Instead, please use number.

[iseki, 2014/09/16 08:44:21]

Done.

+   * @private
+   */
+  this.taskIdCounter_ = 0;
 }
 
 /**
  * Size of drag thumbnail for image files.
  *
  * @type {number}
  * @const
  * @private
  */
 FileTransferController.DRAG_THUMBNAIL_SIZE_ = 64;
@@ skipping 238 matching lines @@
     // work fine.
     var effectAllowed = dataTransfer.effectAllowed !== 'uninitialized' ?
         dataTransfer.effectAllowed : dataTransfer.getData('fs/effectallowed');
     var toMove = util.isDropEffectAllowed(effectAllowed, 'move') &&
         (!util.isDropEffectAllowed(effectAllowed, 'copy') ||
          opt_effect === 'move');
     var destinationEntry =
         opt_destinationEntry || this.currentDirectoryContentEntry;
     var entries;
     var failureUrls;
+    var taskId = this.generateTaskId_();
 
     util.URLsToEntries(sourceURLs).
     then(function(result) {
+      this.pendingTaskId.push(taskId);
       entries = result.entries;
       failureUrls = result.failureUrls;
+      var item = new ProgressCenterItem();
+      item.id = taskId;
+      item.type = ProgressItemType.COPY;
+      item.message = strf('CHECK_FILES_ARE_SHARED');
+      this.progressCenter_.updateItem(item);
       // Check if cross share is needed or not.
       return this.getMultiProfileShareEntries_(entries);
     }.bind(this)).
     then(function(shareEntries) {
       if (shareEntries.length === 0)
         return;
       return this.multiProfileShareDialog_.show(shareEntries.length > 1).
           then(function(dialogResult) {
             if (dialogResult === 'cancel')
               return Promise.reject('ABORT');
@@ skipping 11 matching lines @@
                       fulfill();
                     });
               }).then(requestDriveShare.bind(null, index + 1));
             };
             return requestDriveShare(0);
           });
     }.bind(this)).
     then(function() {
       // Start the pasting operation.
       this.fileOperationManager_.paste(
-          entries, destinationEntry, toMove);
+          entries, destinationEntry, toMove, taskId);
+      this.pendingTaskId.splice(this.pendingTaskId.find(taskId), 1);

[hirono, 2014/09/16 08:12:56]

Array does not have 'find' method.

[iseki, 2014/09/16 08:44:21]

Done.

 
       // Publish events for failureUrls.
       for (var i = 0; i < failureUrls.length; i++) {
         var fileName =
             decodeURIComponent(failureUrls[i].replace(/^.+\//, ''));
         var event = new Event('source-not-found');
         event.fileName = fileName;
         event.progressType =
             toMove ? ProgressItemType.MOVE : ProgressItemType.COPY;
         this.dispatchEvent(event);
@@ skipping 678 matching lines @@
               destinationLocationInfo.volumeInfo.fileSystem.root.toURL() &&
           !event.ctrlKey) {
         return 'move';
       }
       if (event.shiftKey) {
         return 'move';
       }
     }
     return 'copy';
   },
+
+  /**
+   * Generates new task ID.
+   *
+   * @return {string} New task ID.
+   * @private
+   */
+  generateTaskId_: function() {
+    return 'file-operation-from-transfer-controller' + this.taskIdCounter_++;
+  },
 };