Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 571343002: Add notification before getMultiProfileShareEntries_. (Closed)

Created:
6 years, 3 months ago by iseki
Modified:
6 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add notification before getMultiProfileShareEntries_. * getMultiProfileShareEntries_ is very slow. BUG=409711 TEST=manually 1.Copy the large directory in the drive of user A. 2.Paste the A's large directory into the drive of user B. 3.Confirm notification is displayed. Committed: https://crrev.com/fe9b1a17bd8576ce2a42d233d668c469c0379c91 Cr-Commit-Position: refs/heads/master@{#295235}

Patch Set 1 #

Total comments: 20

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Total comments: 12

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -17 lines) Patch
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 2 3 7 chunks +13 lines, -8 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 2 chunks +20 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 2 3 6 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
iseki
Please take a look.
6 years, 3 months ago (2014-09-16 07:55:35 UTC) #2
hirono
https://codereview.chromium.org/571343002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/571343002/diff/1/chrome/app/chromeos_strings.grdp#newcode501 chrome/app/chromeos_strings.grdp:501: Check items are shared. Could you confirm with @bengold ...
6 years, 3 months ago (2014-09-16 08:12:57 UTC) #3
iseki
Thank you for your review. https://codereview.chromium.org/571343002/diff/1/chrome/app/chromeos_strings.grdp File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/571343002/diff/1/chrome/app/chromeos_strings.grdp#newcode501 chrome/app/chromeos_strings.grdp:501: Check items are shared. ...
6 years, 3 months ago (2014-09-16 08:44:21 UTC) #4
hirono
https://codereview.chromium.org/571343002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/571343002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode2824 ui/file_manager/file_manager/foreground/js/file_manager.js:2824: i < this.fileTransferController_.pendingTaskId.length; ++i) { On 2014/09/16 08:44:20, iseki ...
6 years, 3 months ago (2014-09-16 09:01:31 UTC) #5
iseki
Thank you for your review :) https://codereview.chromium.org/571343002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js File ui/file_manager/file_manager/foreground/js/file_manager.js (right): https://codereview.chromium.org/571343002/diff/1/ui/file_manager/file_manager/foreground/js/file_manager.js#newcode2824 ui/file_manager/file_manager/foreground/js/file_manager.js:2824: i < this.fileTransferController_.pendingTaskId.length; ...
6 years, 3 months ago (2014-09-17 01:42:35 UTC) #6
hirono
https://codereview.chromium.org/571343002/diff/40001/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/571343002/diff/40001/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode1192 ui/file_manager/file_manager/background/js/file_operation_manager.js:1192: sourceEntries, targetEntry, isMove, optTaskId) { nit: The type name ...
6 years, 3 months ago (2014-09-17 03:33:20 UTC) #7
iseki
Thank you for your review. https://codereview.chromium.org/571343002/diff/40001/ui/file_manager/file_manager/background/js/file_operation_manager.js File ui/file_manager/file_manager/background/js/file_operation_manager.js (right): https://codereview.chromium.org/571343002/diff/40001/ui/file_manager/file_manager/background/js/file_operation_manager.js#newcode1192 ui/file_manager/file_manager/background/js/file_operation_manager.js:1192: sourceEntries, targetEntry, isMove, optTaskId) ...
6 years, 3 months ago (2014-09-17 04:08:48 UTC) #8
hirono
lgtm. Could you add cancelCallback to the progress item at the separated patch? Thank you!
6 years, 3 months ago (2014-09-17 05:16:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571343002/60001
6 years, 3 months ago (2014-09-17 05:23:45 UTC) #11
iseki
Thanks! I file the bug about it and start this bug.
6 years, 3 months ago (2014-09-17 05:24:12 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as cefd7b6ec2a8a00a453a571f767393bfeeb5f9c4
6 years, 3 months ago (2014-09-17 06:19:41 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 06:20:35 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fe9b1a17bd8576ce2a42d233d668c469c0379c91
Cr-Commit-Position: refs/heads/master@{#295235}

Powered by Google App Engine
This is Rietveld 408576698