Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 571333003: Set spliced LOAD segment's memsz equal to filesz. (Closed)

Created:
6 years, 3 months ago by simonb (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Anton
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set spliced LOAD segment's memsz equal to filesz. Current packing sets the spliced LOAD segment's memsz to larger than its filesz. This causes the runtime linker to create a 'zero' mapping to pad from filesz to memsz. This isn't a problem -- the mapping sits on already reserved address space and uses no real memory -- but 'null' mappings like this appear in /proc/pid/maps and can disrupt or confuse tools which read and parse it, for example Breakpad. This change makes the spliced LOAD segment's memsz and filesz equal. It also tidies code a little so that it is now more obvious when filesz is equal to memsz, and vaddr is equal to paddr. Also, rebuild test data to match. BUG=385553 Committed: https://crrev.com/b344e78c65330d3b2d4f767e91349f2a6004e960 Cr-Commit-Position: refs/heads/master@{#295459}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
simonb (inactive)
6 years, 3 months ago (2014-09-17 11:35:31 UTC) #2
Anton
lgtm
6 years, 3 months ago (2014-09-18 11:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/571333003/1
6 years, 3 months ago (2014-09-18 11:31:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as d33f355aa3ca15084fe40f01f231e3a62733e88a
6 years, 3 months ago (2014-09-18 12:31:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 12:31:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b344e78c65330d3b2d4f767e91349f2a6004e960
Cr-Commit-Position: refs/heads/master@{#295459}

Powered by Google App Engine
This is Rietveld 408576698