Chromium Code Reviews
DescriptionSet spliced LOAD segment's memsz equal to filesz.
Current packing sets the spliced LOAD segment's memsz to larger than
its filesz. This causes the runtime linker to create a 'zero' mapping
to pad from filesz to memsz.
This isn't a problem -- the mapping sits on already reserved address
space and uses no real memory -- but 'null' mappings like this appear
in /proc/pid/maps and can disrupt or confuse tools which read and
parse it, for example Breakpad.
This change makes the spliced LOAD segment's memsz and filesz equal.
It also tidies code a little so that it is now more obvious when
filesz is equal to memsz, and vaddr is equal to paddr.
Also, rebuild test data to match.
BUG=385553
Committed: https://crrev.com/b344e78c65330d3b2d4f767e91349f2a6004e960
Cr-Commit-Position: refs/heads/master@{#295459}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||