Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: extensions/renderer/api/serial/data_sender_unittest.cc

Issue 571333002: Add serialization support to the JS DataSender and DataReceiver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stash-service
Patch Set: address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/serial/data_sender_unittest.cc
diff --git a/extensions/renderer/api/serial/data_sender_unittest.cc b/extensions/renderer/api/serial/data_sender_unittest.cc
index 9f129e077fe23511d0d8b4bab785c518ce69c4c3..18a62367d30aedbefb8b7a2ca0a5f50d3b7e15f9 100644
--- a/extensions/renderer/api/serial/data_sender_unittest.cc
+++ b/extensions/renderer/api/serial/data_sender_unittest.cc
@@ -22,6 +22,8 @@ class DataSenderTest : public ApiTestBase {
env()->RegisterModule("data_sender", IDR_DATA_SENDER_JS);
env()->RegisterModule("device/serial/data_stream.mojom",
IDR_DATA_STREAM_MOJOM_JS);
+ env()->RegisterModule("device/serial/data_stream_serialization.mojom",
+ IDR_DATA_STREAM_SERIALIZATION_MOJOM_JS);
service_provider()->AddService(
base::Bind(&DataSenderTest::CreateDataSink, base::Unretained(this)));
}
@@ -159,4 +161,32 @@ TEST_F(DataSenderTest, Close) {
RunTest("data_sender_unittest.js", "testClose");
}
+TEST_F(DataSenderTest, SendAfterSerialization) {
+ expected_data_.push("aa");
+ RunTest("data_sender_unittest.js", "testSendAfterSerialization");
+}
+
+TEST_F(DataSenderTest, SendErrorAfterSerialization) {
+ expected_data_.push("");
+ expected_data_.push("a");
+ error_to_report_.push(1);
+ RunTest("data_sender_unittest.js", "testSendErrorAfterSerialization");
+}
+
+TEST_F(DataSenderTest, CancelAfterSerialization) {
+ RunTest("data_sender_unittest.js", "testCancelAfterSerialization");
+}
+
+TEST_F(DataSenderTest, SerializeCancelsSendsInProgress) {
+ RunTest("data_sender_unittest.js", "testSerializeCancelsSendsInProgress");
+}
+
+TEST_F(DataSenderTest, SerializeWaitsForCancel) {
+ RunTest("data_sender_unittest.js", "testSerializeWaitsForCancel");
+}
+
+TEST_F(DataSenderTest, SerializeAfterClose) {
+ RunTest("data_sender_unittest.js", "testSerializeAfterClose");
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698