Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: extensions/renderer/api/serial/data_sender_unittest.cc

Issue 571333002: Add serialization support to the JS DataSender and DataReceiver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stash-service
Patch Set: address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/serial/data_sender_unittest.cc
diff --git a/extensions/renderer/api/serial/data_sender_unittest.cc b/extensions/renderer/api/serial/data_sender_unittest.cc
index 9f129e077fe23511d0d8b4bab785c518ce69c4c3..d227c5ccfd494a82f48a243457251f11d85dd6e6 100644
--- a/extensions/renderer/api/serial/data_sender_unittest.cc
+++ b/extensions/renderer/api/serial/data_sender_unittest.cc
@@ -22,6 +22,8 @@ class DataSenderTest : public ApiTestBase {
env()->RegisterModule("data_sender", IDR_DATA_SENDER_JS);
env()->RegisterModule("device/serial/data_stream.mojom",
IDR_DATA_STREAM_MOJOM_JS);
+ env()->RegisterModule("device/serial/data_stream_serialization.mojom",
+ IDR_DATA_STREAM_SERIALIZATION_MOJOM_JS);
service_provider()->AddService(
base::Bind(&DataSenderTest::CreateDataSink, base::Unretained(this)));
}
@@ -159,4 +161,74 @@ TEST_F(DataSenderTest, Close) {
RunTest("data_sender_unittest.js", "testClose");
}
+TEST_F(DataSenderTest, SendWithSerialization) {
+ expected_data_.push("aaa");
+ RunTest("data_sender_unittest.js", "testSendWithSerialization");
+}
+
+TEST_F(DataSenderTest, SendErrorWithSerialization) {
+ expected_data_.push("");
+ expected_data_.push("a");
+ error_to_report_.push(1);
+ expected_data_.push("");
+ expected_data_.push("c");
+ error_to_report_.push(0);
+ error_to_report_.push(3);
+ RunTest("data_sender_unittest.js", "testSendErrorWithSerialization");
+}
+
+TEST_F(DataSenderTest, SendErrorPartialSuccessWithSerialization) {
+ expected_data_.push(std::string(5, 'b'));
+ expected_data_.push("a");
+ error_to_report_.push(1);
+ expected_data_.push(std::string(5, 'c'));
+ expected_data_.push("d");
+ error_to_report_.push(0);
+ error_to_report_.push(3);
+ RunTest("data_sender_unittest.js",
+ "testSendErrorPartialSuccessWithSerialization");
+}
+
+TEST_F(DataSenderTest, SendErrorBetweenPacketsWithSerialization) {
+ expected_data_.push(std::string(2, 'b'));
+ expected_data_.push("a");
+ error_to_report_.push(1);
+ error_to_report_.push(0);
+
+ expected_data_.push(std::string(2, 'c'));
+ expected_data_.push("d");
+ error_to_report_.push(3);
+ RunTest("data_sender_unittest.js",
+ "testSendErrorBetweenPacketsWithSerialization");
+}
+
+TEST_F(DataSenderTest, SendErrorInSecondPacketWithSerialization) {
+ expected_data_.push(std::string(3, 'b'));
+ expected_data_.push("a");
+ error_to_report_.push(1);
+ error_to_report_.push(0);
+ expected_data_.push(std::string(3, 'c'));
+ expected_data_.push("d");
+ error_to_report_.push(3);
+ RunTest("data_sender_unittest.js",
+ "testSendErrorInSecondPacketWithSerialization");
+}
+
+TEST_F(DataSenderTest, CancelWithSerialization) {
+ RunTest("data_sender_unittest.js", "testCancelWithSerialization");
+}
+
+TEST_F(DataSenderTest, SerializeWithSendsInProgress) {
+ RunTest("data_sender_unittest.js", "testSerializeWithSendsInProgress");
+}
+
+TEST_F(DataSenderTest, SerializeWithSendAndCancelInProgress) {
+ RunTest("data_sender_unittest.js",
+ "testSerializeWithSendAndCancelInProgress");
+}
+
+TEST_F(DataSenderTest, SerializeAfterClose) {
+ RunTest("data_sender_unittest.js", "testSerializeAfterClose");
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698