Add serialization support to the JS DataSender and DataReceiver.

extensions/test/data/data_receiver_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Tests launched by extensions/renderer/api/serial/data_receiver_unittest.cc
 
 var test = require('test').binding;
 var unittestBindings = require('test_environment_specific_bindings');
 
 var fatalErrorValue = 2;
 var bufferSize = 10;
 
 function createReceiver() {
   return Promise.all([
     requireAsync('content/public/renderer/service_provider'),
     requireAsync('data_receiver'),
     requireAsync('device/serial/data_stream.mojom'),
   ]).then(test.callbackPass(function(modules) {
     var serviceProvider = modules[0];
     var dataReceiver = modules[1];
     var dataStream = modules[2];
     return new dataReceiver.DataReceiver(
         serviceProvider.connectToService(dataStream.DataSourceProxy.NAME_),
         bufferSize,
         fatalErrorValue);
   }));
 }
 
+function serializeRoundTrip(receiver) {
+  return Promise.all([
+    receiver.serialize(),
+    requireAsync('data_receiver'),
+  ]).then(function(promises) {
+    var serialized = promises[0];
+    var dataReceiver = promises[1];
+    return dataReceiver.DataReceiver.deserialize(serialized);
+  });
+}
+
 unittestBindings.exportTests([
   function testReceive() {
     createReceiver().then(test.callbackPass(function(receiver) {
       receiver.receive().then(test.callbackPass(function(data) {
         test.assertEq(1, data.byteLength);
         test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
         receiver.close();
       }));
       test.assertThrows(
           receiver.receive, receiver, [], 'Receive already in progress.');
@@ skipping 32 matching lines @@
         test.assertEq(1, error.error);
         return receiver.receive();
       })).then(test.callbackPass(function(data) {
         test.assertEq(1, data.byteLength);
         test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
         receiver.close();
       }));
     }));
   },
 
+  function testReceiveWithSerialization() {
+    createReceiver().then(test.callbackPass(function(receiver) {
+      return receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
+        return receiver;
+      }));
+    })).then(test.callbackPass(serializeRoundTrip)).then(test.callbackPass(
+        function(receiver) {
+      receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('b'.charCodeAt(0), new Int8Array(data)[0]);
+        receiver.close();
+      }));
+      test.assertThrows(
+          receiver.receive, receiver, [], 'Receive already in progress.');
+    }));
+  },

[raymes, 2014/09/17 02:05:04]

I find the style that these tests are written in very hard to understand and I
have to stare at it for a long time before I see roughly what is going on. It is
very dense. I'm not sure if it is just me - so if you think it would be easy to
understand for other devs, please CC them for their opinion :)

Rather than having everything inline inside of the test, could we pull out all
the functions definitions to the top of the test and name them. Then below that
we can have the execution chained together with "then". I think this could make
it much clearer to read with fewer brackets and less inline nesting. Could we
try something like that?

[Sam McNally, 2014/09/17 08:07:14]

Done.

+
+  function testReceiveErrorWithSerialization() {
+    createReceiver().then(test.callbackPass(function(receiver) {
+      return receiver.receive().catch(test.callbackPass(function(error) {
+        test.assertEq(1, error.error);
+        return receiver;
+      }));
+    })).then(test.callbackPass(serializeRoundTrip)).then(test.callbackPass(
+        function(receiver) {
+      receiver.receive().catch(test.callbackPass(function(error) {
+        test.assertEq(3, error.error);
+        receiver.close();
+      }));
+    }));
+  },
+
+  function testReceiveDataAndErrorWithSerialization() {
+    createReceiver().then(serializeRoundTrip).then(test.callbackPass(
+        function(receiver) {
+      return receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
+        return receiver.receive();
+      })).catch(test.callbackPass(function(error) {
+        test.assertEq(1, error.error);
+        return receiver;
+      }));
+    })).then(test.callbackPass(serializeRoundTrip)).then(test.callbackPass(
+        function(receiver) {
+      receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('b'.charCodeAt(0), new Int8Array(data)[0]);
+        return receiver.receive();
+      })).catch(test.callbackPass(function(error) {
+        test.assertEq(3, error.error);
+        return receiver.receive();
+      })).then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('c'.charCodeAt(0), new Int8Array(data)[0]);
+        receiver.close();
+      }));
+    }));
+  },
+
+  function testReceiveErrorThenDataWithSerialization() {
+    createReceiver().then(test.callbackPass(function(receiver) {
+      return receiver.receive().catch(test.callbackPass(function(error) {
+        test.assertEq(1, error.error);
+        return receiver;
+      }));
+    })).then(test.callbackPass(serializeRoundTrip)).then(test.callbackPass(
+        function(receiver) {
+      receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
+        receiver.close();
+      }));
+    }));
+  },
+
+  function testSerializeDuringReceive() {
+    createReceiver().then(test.callbackPass(function(receiver) {
+      receiver.receive().catch(test.callbackPass(function(error) {
+        test.assertEq(fatalErrorValue, error.error);
+      }));
+      return receiver;
+    })).then(test.callbackPass(serializeRoundTrip)).then(test.callbackPass(
+        function(receiver) {
+      receiver.receive().then(test.callbackPass(function(data) {
+        test.assertEq(1, data.byteLength);
+        test.assertEq('a'.charCodeAt(0), new Int8Array(data)[0]);
+        receiver.close();
+      }));
+    }));
+  },
+
   function testSourceShutdown() {
     createReceiver().then(test.callbackPass(function(receiver) {
       receiver.receive().catch(test.callbackPass(function(error) {
         test.assertEq(fatalErrorValue, error.error);
         receiver.close();
       }));
     }));
   },
 
 ], test.runTests, exports);