Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 571283006: Revert of Use chromeos accelerometer reader and support only lid accelerometer. (Closed)

Created:
6 years, 3 months ago by battre
Modified:
6 years, 3 months ago
Reviewers:
flackr, Daniel Erat, oshima
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Use chromeos accelerometer reader and support only lid accelerometer. (patchset #3 id:60001 of https://codereview.chromium.org/574113002/) Reason for revert: Breaks ChromeOS compilation http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/11155/steps/compile/logs/stdio Original issue's description: > Use chromeos accelerometer reader in athena and support only lid accelerometer. > > BUG=380831 > TEST=Glimmer/clapper still work, manually tested not having a base accelerometer. > > Committed: https://crrev.com/2aa8d2e93a06cc7673c872704c04e933bd6cc252 > Cr-Commit-Position: refs/heads/master@{#295258} TBR=derat@chromium.org,oshima@chromium.org,flackr@chromium.org NOTREECHECKS=true NOTRY=true BUG=380831 Committed: https://crrev.com/59fb217ef1e758e1541415b0795b584f30d5a7f0 Cr-Commit-Position: refs/heads/master@{#295262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+573 lines, -132 lines) Patch
M athena/athena.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M athena/main/athena_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/main/athena_main.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A athena/system/device_socket_listener.h View 1 chunk +48 lines, -0 lines 0 comments Download
A athena/system/device_socket_listener.cc View 1 chunk +310 lines, -0 lines 0 comments Download
M athena/system/orientation_controller.h View 2 chunks +38 lines, -9 lines 0 comments Download
M athena/system/orientation_controller.cc View 2 chunks +103 lines, -12 lines 0 comments Download
M athena/system/system_ui_impl.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M athena/test/athena_test_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/accelerometer/accelerometer_reader.h View 2 chunks +6 lines, -12 lines 0 comments Download
M chromeos/accelerometer/accelerometer_reader.cc View 7 chunks +52 lines, -84 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
battre
Created Revert of Use chromeos accelerometer reader and support only lid accelerometer.
6 years, 3 months ago (2014-09-17 12:52:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571283006/1
6 years, 3 months ago (2014-09-17 12:54:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0833fddd8d8f90b2a9704014855d8c7b7b710f5d
6 years, 3 months ago (2014-09-17 12:55:08 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 12:55:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59fb217ef1e758e1541415b0795b584f30d5a7f0
Cr-Commit-Position: refs/heads/master@{#295262}

Powered by Google App Engine
This is Rietveld 408576698