Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 571273003: Fix failing DCHECKs in JingleSession added in r294653 (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix failing DCHECKs in JingleSession added in r294653 r294653 added two DCHECKs in JingleSession in CancelChannelCreation() and destructor. These checks were failing in the client sometimes. This CL fixes the code that was causing them to fail: 1. The ChannelMultiplexer needs to be destroyed explicitly in the destructor. 2. ChannelDispatcherBase was calling CancelChannelCreation() even after the channel is created. Committed: https://crrev.com/d04beefcfe9d886bd0938ce409b2236482c6c1b8 Cr-Commit-Position: refs/heads/master@{#295138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/protocol/channel_dispatcher_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergey Ulanov
6 years, 3 months ago (2014-09-16 01:35:47 UTC) #2
Wez
lgtm
6 years, 3 months ago (2014-09-16 19:23:00 UTC) #4
Wez
Can these two issues be easily unit-tested for, to prevent regressions?
6 years, 3 months ago (2014-09-16 19:23:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571273003/1
6 years, 3 months ago (2014-09-16 19:23:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 998c7ce8c1b07821416e98b27a92476013c1d33f
6 years, 3 months ago (2014-09-16 20:24:07 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 20:25:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d04beefcfe9d886bd0938ce409b2236482c6c1b8
Cr-Commit-Position: refs/heads/master@{#295138}

Powered by Google App Engine
This is Rietveld 408576698