Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 571273002: Fix execution order to prevent browserTest being undefined. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix execution order to prevent browserTest being undefined. For apps v1, authentication involves navigating away from the app and then back again, so loading browser_test.js before authentication doesn't work. I don't know why this is a recent regression though--AFAICT it should have been failing from day 1. BUG=414498 Committed: https://crrev.com/c41d7ca38f277cce2c6f6a3b669b623a32d847e2 Cr-Commit-Position: refs/heads/master@{#295091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/remoting/remote_desktop_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Jamie
ptal
6 years, 3 months ago (2014-09-16 01:00:48 UTC) #2
kelvinp
lgtm
6 years, 3 months ago (2014-09-16 01:04:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571273002/1
6 years, 3 months ago (2014-09-16 01:11:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/13998)
6 years, 3 months ago (2014-09-16 02:41:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571273002/1
6 years, 3 months ago (2014-09-16 16:34:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as fd80f081852eb99c33f5444895bba725b506baf2
6 years, 3 months ago (2014-09-16 17:21:18 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 17:22:36 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c41d7ca38f277cce2c6f6a3b669b623a32d847e2
Cr-Commit-Position: refs/heads/master@{#295091}

Powered by Google App Engine
This is Rietveld 408576698