Reland 21774: Generate KeyedLoadGeneric with Hydrogen

src/hydrogen-dehoist.cc

Index: src/hydrogen-dehoist.cc
diff --git a/src/hydrogen-dehoist.cc b/src/hydrogen-dehoist.cc
index bdf2cfb258409afb10c0466e389533c745fbfd42..e48801c613a3c991d1db57aa51b714c7bcb6fe36 100644
--- a/src/hydrogen-dehoist.cc
+++ b/src/hydrogen-dehoist.cc
@@ -53,12 +53,13 @@ static void DehoistArrayIndex(ArrayInstructionInterface* array_operation) {
   int32_t value = constant->Integer32Value() * sign;
   // We limit offset values to 30 bits because we want to avoid the risk of
   // overflows when the offset is added to the object header size.
-  if (value >= 1 << array_operation->MaxIndexOffsetBits() || value < 0) return;
+  if (value >= 1 << array_operation->MaxBaseOffsetBits() || value < 0) return;

[Toon Verwaest, 2013/12/04 17:29:26]

"value >= 1 << ..." is quite hard to understand. Could we extract this to
temporary variables that declare their meaning?

[danno, 2014/06/06 15:43:50]

Done.

   array_operation->SetKey(subexpression);
   if (binary_operation->HasNoUses()) {
     binary_operation->DeleteAndReplaceWith(NULL);
   }
-  array_operation->SetIndexOffset(static_cast<uint32_t>(value));
+  value <<= ElementsKindToShiftSize(array_operation->elements_kind());
+  array_operation->IncreaseBaseOffset(static_cast<uint32_t>(value));
   array_operation->SetDehoisted(true);
 }