Reland 21774: Generate KeyedLoadGeneric with Hydrogen

src/elements-kind.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 47 matching lines @@
     case FAST_HOLEY_ELEMENTS:
     case DICTIONARY_ELEMENTS:
     case NON_STRICT_ARGUMENTS_ELEMENTS:
       return kPointerSizeLog2;
   }
   UNREACHABLE();
   return 0;
 }
 
 
+int GetDefaultHeaderSizeForElementsKind(ElementsKind elements_kind) {
+  return IsExternalArrayElementsKind(elements_kind)
+      ? 0 : (FixedArray::kHeaderSize - kSmiTagSize);

[Toon Verwaest, 2013/12/04 17:29:26]

Shouldn't that be kHeapObjectTag rather than kSmiTagSize?
Also, this relies on FixedArray::kHeaderSize being equal to
FixedDoubleArray::kHeaderSize. Please add an ASSERT to that effect.

[danno, 2014/06/06 15:43:50]

Done.

+}
+
+
 const char* ElementsKindToString(ElementsKind kind) {
   ElementsAccessor* accessor = ElementsAccessor::ForKind(kind);
   return accessor->name();
 }
 
 
 void PrintElementsKind(FILE* out, ElementsKind kind) {
   PrintF(out, "%s", ElementsKindToString(kind));
 }
 
@@ skipping 91 matching lines @@
       return to_kind == FAST_HOLEY_ELEMENTS;
     case FAST_HOLEY_ELEMENTS:
       return false;
     default:
       return false;
   }
 }
 
 
 } }  // namespace v8::internal