Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 571213003: Revert "Embedded Extension Options: remove flags and trunk channel restrictions" (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Embedded Extension Options: remove flags and trunk channel restrictions" This reverts commit f51d745370bf88beeb3e9a5da4a64b5cebea8028. The UI is breaking with certain extensions and users have no ability to work around this. Putting back behind a flag and trunk-only restriction. BUG=414497, 474476 CC=jleichtling@chromium.org,amineer@chromium.org TBR=kalman@chromium.org,fsamuel@chromium.org Committed: https://crrev.com/19f0e7ff09a8c6692327869cf0716d686762a16b Cr-Commit-Position: refs/heads/master@{#294933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_webui_apitest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_apitest.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/common/feature_switch.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/feature_switch.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M extensions/common/manifest_handlers/options_page_info.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/switches.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Rockot(use gerrit already)
Committed patchset #1 (id:1) manually as 19f0e7f (presubmit successful).
6 years, 3 months ago (2014-09-16 00:00:12 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/19f0e7ff09a8c6692327869cf0716d686762a16b Cr-Commit-Position: refs/heads/master@{#294933}
6 years, 3 months ago (2014-09-16 00:00:16 UTC) #2
not at google - send to devlin
6 years, 3 months ago (2014-09-16 08:27:36 UTC) #3
Message was sent while issue was closed. 
Yeah - this patch wasn't the right approach, oops. I had intended (I guess only
within my own mind) that the behaviour be opt-in for now but the manifest key
available on stable channel. Which is contrary to what I've been saying.

Powered by Google App Engine
This is Rietveld 408576698