Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Issue 571203003: Remove guava dependency for multiple_proguards test. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-more-guava-dependencies
Project:
chromium
Visibility:
Public.

Description

Remove guava dependency for multiple_proguards test. The multiple_proguards_test_apk target used guava as an example for something that needed to be proguarded out to ensure no proguard warnings. Since guava is going away, this CL moves the bad code into chromium directly so there is no need for guava. It does bad things which produce warnings, so they are silenced by telling GYP that it is not chromium code. BUG=412673 Committed: https://crrev.com/1c8fb8003d7d8e338c0bd277d3ab6bdff97e75df Cr-Commit-Position: refs/heads/master@{#294950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M build/android/tests/multiple_proguards/multiple_proguards.gyp View 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/tests/multiple_proguards/proguard1.flags View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/tests/multiple_proguards/proguard2.flags View 1 chunk +1 line, -3 lines 0 comments Download
M build/android/tests/multiple_proguards/src/dummy/DummyActivity.java View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nyquist
cjhopman: PTAL
6 years, 3 months ago (2014-09-15 21:38:00 UTC) #2
cjhopman
lgtm
6 years, 3 months ago (2014-09-15 21:53:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571203003/1
6 years, 3 months ago (2014-09-15 22:56:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as eb9de007e7f5daf130fc8745f15ca20516a434f8
6 years, 3 months ago (2014-09-16 00:54:14 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 00:56:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c8fb8003d7d8e338c0bd277d3ab6bdff97e75df
Cr-Commit-Position: refs/heads/master@{#294950}

Powered by Google App Engine
This is Rietveld 408576698