Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 571143002: Pass -std=gnu++0x in build_nexe.py. (Closed)

Created:
6 years, 3 months ago by Nico
Modified:
6 years, 3 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Pass -std=gnu++0x in build_nexe.py. Doing this here instead of untrusted.gypi since the option isn't valid for C files. BUG=chromium:414314 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg,linux_arm_cross_compile R=dschuff@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13748

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/build_nexe.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Nico
6 years, 3 months ago (2014-09-15 16:29:29 UTC) #2
Derek Schuff
LGTM. I would say to add to a comment/commit message that this is for arm-nacl-gcc ...
6 years, 3 months ago (2014-09-15 16:33:04 UTC) #3
Nico
On 2014/09/15 16:33:04, Derek Schuff wrote: > LGTM. Thanks. > I would say to add ...
6 years, 3 months ago (2014-09-15 16:36:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571143002/20001
6 years, 3 months ago (2014-09-15 16:38:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571143002/40001
6 years, 3 months ago (2014-09-15 16:41:54 UTC) #8
Nico
(switched back to 0x, because http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_glibc_opt/builds/8341/steps/gyp_compile/logs/stdio didn't like 11)
6 years, 3 months ago (2014-09-15 16:42:05 UTC) #9
Nico
On 2014/09/15 16:42:05, Nico (hiding) wrote: > (switched back to 0x, because > http://build.chromium.org/p/tryserver.nacl/builders/nacl-mac10.7_glibc_opt/builds/8341/steps/gyp_compile/logs/stdio > ...
6 years, 3 months ago (2014-09-15 16:42:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571143002/60001
6 years, 3 months ago (2014-09-15 16:46:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_nacl_sdk on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_nacl_sdk/builds/87) linux_rel_precise32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_rel_precise32/builds/103) nacl-win8-64_newlib_dbg ...
6 years, 3 months ago (2014-09-15 16:51:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571143002/80001
6 years, 3 months ago (2014-09-15 17:10:46 UTC) #16
Derek Schuff
On 2014/09/15 17:10:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 3 months ago (2014-09-15 17:13:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel_precise32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_rel_precise32/builds/105)
6 years, 3 months ago (2014-09-15 17:13:57 UTC) #19
Nico
Committed patchset #5 (id:80001) manually as r13748 (tree was closed).
6 years, 3 months ago (2014-09-15 17:19:50 UTC) #20
Nico
On 2014/09/15 17:19:50, Nico (hiding) wrote: > Committed patchset #5 (id:80001) manually as r13748 (tree ...
6 years, 3 months ago (2014-09-15 17:20:12 UTC) #21
Nico
6 years, 3 months ago (2014-09-15 17:20:31 UTC) #22
Message was sent while issue was closed.
On 2014/09/15 17:20:12, Nico (hiding) wrote:
> On 2014/09/15 17:19:50, Nico (hiding) wrote:
> > Committed patchset #5 (id:80001) manually as r13748 (tree was closed).
> 
> (the additional cq bots failed during "bot_update", which looks unrelated.)

…and patch set 1 has very green try results, and it's the same diff as patch set
5)

Powered by Google App Engine
This is Rietveld 408576698