Fix some properties on the settings page read from ONC.

Fix some properties on the settings page read from ONC.

- Fixed AutoConnect, which is stored in each network type's subdictionary.
- Added a Cellular.AutoConnect property to ONC.
- Fixed VPN username for L2TP-IPsec, which is stored in 'L2TP'.
- Removed reading Wimax properties from ONC, as these are not yet supported.

BUG=412807
Committed: https://crrev.com/30a7d44dd3fd802dc431671b6f065796d102a2d2
Cr-Commit-Position: refs/heads/master@{#294897}

[pneubeck (no reviews), 2014-09-15 15:27:26]

Patchset #1 (id:1) has been deleted

[pneubeck (no reviews), 2014-09-15 15:27:42]

pneubeck@chromium.org changed reviewers:
+ stevenjb@chromium.org

[pneubeck (no reviews), 2014-09-15 15:27:43]

ptal

I can add Wimax tomorrow.

[stevenjb, 2014-09-15 16:38:41]

Thanks for addressing these.

lgtm w/ TODO added to comments.

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:1321: var identity;
// = onc.getActiveValue('Wimax.EAP.Identity');
Do we actually need to remove this? The code should be equally broken either
way. If we do need to comment this out, please add a TODO.

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:396: // Wimax is not
supported by ONC, yet.
Let's make sure there is a big TODO here, even if we plan to follow this up
immediately.

[pneubeck (no reviews), 2014-09-15 20:22:36]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-09-15 20:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/571123002/40001

[pneubeck (no reviews), 2014-09-15 20:27:14]

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:1321: var identity;
// = onc.getActiveValue('Wimax.EAP.Identity');
On 2014/09/15 16:38:41, stevenjb wrote:
> Do we actually need to remove this? The code should be equally broken either
> way. If we do need to comment this out, please add a TODO.
> 

As discussed this should already handle it gracefully, if the properties are not
existent.
Keeping the original code.

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:396: // Wimax is not
supported by ONC, yet.
On 2014/09/15 16:38:41, stevenjb wrote:
> Let's make sure there is a big TODO here, even if we plan to follow this up
> immediately.

Done.

[pneubeck (no reviews), 2014-09-15 20:27:14]

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/571123002/diff/20001/chrome/browser/resources...
chrome/browser/resources/options/chromeos/internet_detail.js:1321: var identity;
// = onc.getActiveValue('Wimax.EAP.Identity');
On 2014/09/15 16:38:41, stevenjb wrote:
> Do we actually need to remove this? The code should be equally broken either
> way. If we do need to comment this out, please add a TODO.
> 

As discussed this should already handle it gracefully, if the properties are not
existent.
Keeping the original code.

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
File chromeos/network/onc/onc_translator_shill_to_onc.cc (right):

https://codereview.chromium.org/571123002/diff/20001/chromeos/network/onc/onc...
chromeos/network/onc/onc_translator_shill_to_onc.cc:396: // Wimax is not
supported by ONC, yet.
On 2014/09/15 16:38:41, stevenjb wrote:
> Let's make sure there is a big TODO here, even if we plan to follow this up
> immediately.

Done.

[commit-bot: I haz the power, 2014-09-15 21:48:09]

Committed patchset #2 (id:40001) as c354c47e4f7bcd665c54f32f6fc0dc101cf34068

[commit-bot: I haz the power, 2014-09-15 21:51:43]

Patchset 2 (id:??) landed as
https://crrev.com/30a7d44dd3fd802dc431671b6f065796d102a2d2
Cr-Commit-Position: refs/heads/master@{#294897}