Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 571083002: Adding a preloadScanner watch list, and adding myself (Closed)

Created:
6 years, 3 months ago by Yoav Weiss
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adding a preloadScanner watch list, and adding myself I'm interested in following up changes to the preloadScanner and to prerender. Therefore, I created a preloadScanner WatchList rule, added myself to it and to the prerender watchlist. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182003

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M WATCHLISTS View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoav Weiss
6 years, 3 months ago (2014-09-15 14:10:21 UTC) #1
danakj
LGTM https://codereview.chromium.org/571083002/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/571083002/diff/1/WATCHLISTS#newcode86 WATCHLISTS:86: 'filepath': 'Source/core/html/parser/HTMLPreloadScanner' , at the end
6 years, 3 months ago (2014-09-15 19:34:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571083002/20001
6 years, 3 months ago (2014-09-15 19:45:55 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 20:42:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182003

Powered by Google App Engine
This is Rietveld 408576698