Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 571073003: Make the GPU feature info code more compact. (Closed)

Created:
6 years, 3 months ago by Daniel Bratell
Modified:
6 years, 2 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the GPU feature info code more compact. AddExtensionString is called quite a lot, always with a constant string literal, which makes it a bit unnecessary to convert the argument to a std::string before every function call. This small change cuts away 7 KB of the machine code: Total change: -7208 bytes ========================= 1 added, totalling +559 bytes across 1 sources 1 removed, totalling -471 bytes across 1 sources 1 shrunk, for a net change of -7296 bytes (25422 bytes before, 18126 bytes after) across 1 sources 267984 unchanged, totalling 50299073 bytes Per-source Analysis: -------------------------------------------------------------------------------------------------------------------- -7208 - Source: /home/bratell/src/chromium/src/gpu/command_buffer/service/feature_info.cc - (gained 559, lost 7767) -------------------------------------------------------------------------------------------------------------------- New symbols: +559: gpu::gles2::FeatureInfo::AddExtensionString(char const*) type=t, size=559 bytes Removed symbols: -471: gpu::gles2::FeatureInfo::AddExtensionString(std::string const&) type=t, size=471 bytes Shrunk symbols: -7296: gpu::gles2::FeatureInfo::InitializeFeatures() type=t, (was 25422 bytes, now 18126 bytes) BUG= Committed: https://crrev.com/6a4eb0c42d3f1b29f82b7e49f33b89ea6eadc6a9 Cr-Commit-Position: refs/heads/master@{#296785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Bratell
bajones, can you take a look at this? Just something I tripped over when looking ...
6 years, 3 months ago (2014-09-18 15:42:28 UTC) #2
bajones
On 2014/09/18 at 15:42:28, bratell wrote: > bajones, can you take a look at this? ...
6 years, 3 months ago (2014-09-18 15:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/571073003/1
6 years, 2 months ago (2014-09-25 17:18:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as e9eea0f241f2e9801beb4691ccedaa8a43161967
6 years, 2 months ago (2014-09-25 20:45:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 20:46:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a4eb0c42d3f1b29f82b7e49f33b89ea6eadc6a9
Cr-Commit-Position: refs/heads/master@{#296785}

Powered by Google App Engine
This is Rietveld 408576698