Issue 571043003: Conver mojo visibility to be a list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 571043003: Conver mojo visibility to be a list. (Closed)

Created:
6 years, 3 months ago by brettw

Modified:
6 years, 3 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Conver mojo visibility to be a list. The GN on trunk requires this. Committed: https://crrev.com/e77127ef301e01113d236d53a826447e28543d0b Cr-Commit-Position: refs/heads/master@{#294952}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/views/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm, but i thought these were equivalent. guessing something appends?

6 years, 3 months ago (2014-09-15 23:08:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571043003/1

6 years, 3 months ago (2014-09-15 23:32:15 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 5915beca34c8f341ee170758b03fe55df8bd0932

6 years, 3 months ago (2014-09-16 00:56:29 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 01:01:55 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e77127ef301e01113d236d53a826447e28543d0b
Cr-Commit-Position: refs/heads/master@{#294952}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages