Make OAuth2TokenService::Request class multi-login aware.

Make OAuth2TokenService::Request class multi-login aware.

BUG=277149
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232941

[Roger Tawa OOO till Jul 10th, 2013-11-03 14:52:33]

Hi Filip, Drew, please take a look.  Thanks.

[Roger Tawa OOO till Jul 10th, 2013-11-03 17:15:00]

Hi Xiyuan,

Can you look at the device_oauth2_token_service changes?  Thanks.

[xiyuan, 2013-11-03 18:55:16]

DO2TS LGTM

[fgorski, 2013-11-04 22:08:36]

lgtm

[commit-bot: I haz the power, 2013-11-04 23:51:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/57103002/130001

[commit-bot: I haz the power, 2013-11-05 03:21:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rogerta@chromium.org/57103002/130001

[commit-bot: I haz the power, 2013-11-05 07:12:55]

Change committed as 232941

[Andrew T Wilson (Slow), 2013-11-05 09:28:47]

https://codereview.chromium.org/57103002/diff/130001/google_apis/gaia/oauth2_...
File google_apis/gaia/oauth2_token_service.h (right):

https://codereview.chromium.org/57103002/diff/130001/google_apis/gaia/oauth2_...
google_apis/gaia/oauth2_token_service.h:59: virtual std::string GetAccountId()
const = 0;
Why is this necessary? Nobody calls this, and it seems like a pollution of the
public API for Request (Request is just supposed to be an opaque class that has
nothing but a destructor).

[Roger Tawa OOO till Jul 10th, 2013-11-05 13:32:18]

Hi Drew,

As always, I'm trying to keep CLs small to make them easier to review. To
see where this is used, take a look at the account reconcilor in
https://codereview.chromium.org/57363003/
 On Nov 5, 2013 4:28 AM, <atwilson@chromium.org> wrote:

>
> https://codereview.chromium.org/57103002/diff/130001/
> google_apis/gaia/oauth2_token_service.h
> File google_apis/gaia/oauth2_token_service.h (right):
>
> https://codereview.chromium.org/57103002/diff/130001/
> google_apis/gaia/oauth2_token_service.h#newcode59
> google_apis/gaia/oauth2_token_service.h:59: virtual std::string
> GetAccountId() const = 0;
> Why is this necessary? Nobody calls this, and it seems like a pollution
> of the public API for Request (Request is just supposed to be an opaque
> class that has nothing but a destructor).
>
> https://codereview.chromium.org/57103002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.