Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 571003002: Dispose ApplicationCacheHost on DocumentLoader finalization. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Project:
blink
Visibility:
Public.

Description

Dispose ApplicationCacheHost on DocumentLoader finalization. To cater to Oilpan, introduce an explicit dispose() for ApplicationCacheHost, which the DocumentLoader will call upon when being finalized. Without it, a DocumentLoader might clear the Persistent reference to its ApplicationCacheHost, but it'll still be accessible to embedder notifications via its WebApplicationCacheHost until the next Oilpan GC strikes. If so, the callbacks might access a now-dead DocumentLoader. R=ager BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181973

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/core/loader/DocumentLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
Please take a look. Addressing the http/tests/appcache ASAN failures after https://codereview.chromium.org/552733003/ Regarding naming, eventually landed ...
6 years, 3 months ago (2014-09-15 08:39:50 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-15 09:24:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/571003002/1
6 years, 3 months ago (2014-09-15 11:58:03 UTC) #6
haraken
LGTM
6 years, 3 months ago (2014-09-15 12:18:51 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 12:32:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181973

Powered by Google App Engine
This is Rietveld 408576698