Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 570983002: Adding DumpAccessibilityTree Tests (8 of 20) (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, mkwst+moarreviews-content_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding DumpAccessibilityTree Tests (8 of 20) HTML Tags: object, ins, mark, i, legend, frameset, caption, body, th Aria role: row, spinbutton Aria state/property: aria-atomic BUG=170580 Committed: https://crrev.com/ad03444a481cf5618dcf40b9449b7ace8fee15e7 Cr-Commit-Position: refs/heads/master@{#294800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -23 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 9 chunks +40 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-mac.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-atomic-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row.html View 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-android.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-mac.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-row-expected-win.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/body.html View 1 chunk +1 line, -3 lines 0 comments Download
A content/test/data/accessibility/body-expected-android.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/body-expected-mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/body-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption.html View 1 chunk +22 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-android.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-mac.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/caption-expected-win.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/frameset.html View 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/frameset-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/frameset-expected-mac.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/frameset-expected-win.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-android.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-mac.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/i-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-mac.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/ins-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend.html View 1 chunk +17 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-android.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-mac.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/legend-expected-win.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark.html View 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-android.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-mac.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/mark-expected-win.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/object.html View 1 chunk +9 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/object-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/object-expected-mac.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/object-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/table-simple.html View 1 chunk +7 lines, -5 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-android.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/table-simple-expected-mac.txt View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks! (Previous revision for adding accessibility test was reverted due to flaky failiures ...
6 years, 3 months ago (2014-09-15 06:18:24 UTC) #2
dmazzoni
lgtm
6 years, 3 months ago (2014-09-15 06:22:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570983002/1
6 years, 3 months ago (2014-09-15 06:23:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a34be967640077413bc5849e0db68e53041ddda5
6 years, 3 months ago (2014-09-15 10:40:39 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 10:44:36 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ad03444a481cf5618dcf40b9449b7ace8fee15e7
Cr-Commit-Position: refs/heads/master@{#294800}

Powered by Google App Engine
This is Rietveld 408576698