Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 570933004: Remove tabs from build/all.gyp and replace with spaces (Closed)

Created:
6 years, 3 months ago by David Abrahams
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove tabs from build/all.gyp and replace with spaces My previous checking mistakenly used tabs. replacing them with spaces as required by the style guide. https://codereview.chromium.org/545103003/ Committed: https://crrev.com/b88bd7efc0f53f21c906cc7fbda8416a4e9f9e84 Cr-Commit-Position: refs/heads/master@{#295122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
David Abrahams
6 years, 3 months ago (2014-09-15 22:00:16 UTC) #2
mikecase (-- gone --)
lgtm
6 years, 3 months ago (2014-09-15 22:29:14 UTC) #4
jbudorick
lgtm
6 years, 3 months ago (2014-09-15 22:29:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570933004/1
6 years, 3 months ago (2014-09-16 18:00:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as f435268a854bcb548c2beca2c580ff3b65972fa9
6 years, 3 months ago (2014-09-16 19:19:18 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:20:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b88bd7efc0f53f21c906cc7fbda8416a4e9f9e84
Cr-Commit-Position: refs/heads/master@{#295122}

Powered by Google App Engine
This is Rietveld 408576698