Issue 570933002: Margins should expand/shrink an element's width if no float constrains it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 570933002: Margins should expand/shrink an element's width if no float constrains it (Closed)

Created:
6 years, 3 months ago by rhogan

Modified:
6 years, 3 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Margins should expand/shrink an element's width if no float constrains it This is a regression from https://src.chromium.org/viewvc/blink?revision=175325&view=revision. I didn't consider the case where there are floats in the same formatting context but they don't actually overlap with the element so have no effect on its width. BUG=413202 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181998

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -3 lines)			Patch
A	LayoutTests/fast/block/containing-block-negative-margins.html	View	1 chunk	+52 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/block/containing-block-negative-margins-expected.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBox.cpp	View	1 chunk	+11 lines, -3 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570933002/1

6 years, 3 months ago (2014-09-15 18:58:17 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-15 19:04:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 181998