Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 570863002: Create a dummy resource for PluginPlaceholderElement.js. (Closed)

Created:
4 years, 2 months ago by jbroman
Modified:
4 years, 2 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, jamesr
Project:
blink
Visibility:
Public.

Description

Create a dummy resource for PluginPlaceholderElement.js. This prepares for the landing of https://codereview.chromium.org/522783002/ which now requires a three-sided change due to changes in how Blink accesses private script resources. Part 2: https://codereview.chromium.org/556793006/ BUG=364716 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A Source/core/html/shadow/PluginPlaceholderElement.js View 1 chunk +7 lines, -0 lines 0 comments Download
M public/blink_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
4 years, 2 months ago (2014-09-15 12:59:16 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2014-09-15 14:25:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/570863002/1
4 years, 2 months ago (2014-09-15 14:32:32 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2014-09-15 14:37:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181980

Powered by Google App Engine
This is Rietveld 408576698